feat(native-filter): Hide native filters #14784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � superset-frontend/src/dashboard/util/getPermissions.ts
Codecov Report
@@ Coverage Diff @@
## master #14784 +/- ##
=======================================
Coverage 77.61% 77.62%
=======================================
Files 963 963
Lines 49246 49246
Branches 6197 6198 +1
=======================================
+ Hits 38224 38226 +2
+ Misses 10821 10820 -1
+ Partials 201 200 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
junlincc
added
the
dashboard:native-filters
junlincc
added
need:qa-review
villebro
reviewed
May 26, 2021
| export function getUrlParam(paramName: string, type: 'boolean'): boolean; | ||
| export function getUrlParam(paramName: string, type: UrlParamType): unknown { | ||
| export type UrlParamType = 'string' | 'number' | 'boolean' | 'object'; | ||
| export type ParamNameType = typeof URL_PARAMS[keyof typeof URL_PARAMS]; |
There was a problem hiding this comment.
is this not the same as string? I believe it should be export type ParamNameType = keyof typeof URL_PARAMS;
There was a problem hiding this comment.
This is one of those common cases that we might want to put in our wiki
There was a problem hiding this comment.
I changed to object so this notation protect user from put some wrong object that doesn't exists in URL_PARAMS
geido
approved these changes
May 26, 2021
junlincc
added
need:more-info
villebro
approved these changes
May 31, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* fix:fix get permission function * feat: support showFilters * fix: fix CR notes * fix: fix lint issues
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* fix:fix get permission function * feat: support showFilters * fix: fix CR notes * fix: fix lint issues
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* fix:fix get permission function * feat: support showFilters * fix: fix CR notes * fix: fix lint issues
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
For Thumbnails or Alerts and Reports we need to hide filters bar on first loading
if we pass
show_filters=falsein url on first loading filter bar will be collapsed even if there are some filtersBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION