Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter type are listed as viz type #14308

Closed
3 tasks done
graceguo-supercat opened this issue Apr 23, 2021 · 7 comments · Fixed by #14814
Closed
3 tasks done

filter type are listed as viz type #14308

graceguo-supercat opened this issue Apr 23, 2021 · 7 comments · Fixed by #14814
Assignees
Labels
#bug Bug report dashboard:native-filters Related to the native filters of the Dashboard P1 Priority item - Major

Comments

@graceguo-supercat
Copy link

graceguo-supercat commented Apr 23, 2021

open chart list view and check viz type dropdown list:

Select filter, Time column, Time filter etc, are filter type not viz type.

Screenshots

Screen Shot 2021-04-22 at 8 59 02 PM

Environment

latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

cc @junlincc @villebro

@graceguo-supercat graceguo-supercat added the #bug Bug report label Apr 23, 2021
@villebro
Copy link
Member

thanks for reporting this @graceguo-supercat !

@amitmiran137
Copy link
Member

Should we have a config saying use native filters as Viz type?
This can be useful when there is a need to use one of the the native filter as a chart next/above/below a other chart where visual proximity to the chart might be useful in specific use-cases

@junlincc
Copy link
Member

Screen Shot 2021-04-27 at 10 39 46 PM

this is problematic as well 🤣 @simcha90 @amitmiran137 by default, we should hide all the filter types from all UI except in the filter itself. could we open a PR to add the config?

@villebro
Copy link
Member

IMO there's two things here:

  1. The viz type gallery should have a separate tab/section for plugins that are primarily native filters but can be added as regular viz components to a dashboard (for the use case @amitmiran137 described above). I'm ok to add a config to enable/disable native filters as regular viz components, but I think it should be enabled by default. I don't see the harm in having the option to place native filters on the dashboard as opposed to the filter tab.
  2. Regarding the problem stated in the original issue, that dropdown needs to list all viz types that are supported in the viz type gallery.

@rusackas
Copy link
Member

@suddjian this may relate to other work you're looking into regarding plugin metadata options

@junlincc junlincc added the P1 Priority item - Major label May 21, 2021
@junlincc junlincc added this to To do in Native dashboard filters via automation May 21, 2021
@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label May 21, 2021
@junlincc
Copy link
Member

let's move group-by, drill-down, filter chart components behind a new leading edge feature-flag.

@villebro @simcha90 @amitmiran137 @zhaoyongjie

@villebro
Copy link
Member

Sounds good - I propose calling the feature flag DASHBOARD_NATIVE_FILTERS_EXPERIMENTAL and having all unpolished features there.

@villebro villebro self-assigned this May 25, 2021
@villebro villebro moved this from To do to Assigned in Native dashboard filters May 25, 2021
@junlincc junlincc moved this from Assigned to In progress in Native dashboard filters May 25, 2021
Native dashboard filters automation moved this from In progress to Done May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report dashboard:native-filters Related to the native filters of the Dashboard P1 Priority item - Major
Projects
No open projects
5 participants