Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(native-filter): Default value multi-select height in native filters #14816

Merged
merged 4 commits into from
May 27, 2021
Merged

fix(native-filter): Default value multi-select height in native filters #14816

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c9dce8
Fix height
geido May 25, 2021
d986864
Fix height sidebar
geido May 25, 2021
613e1af
Merge
geido May 26, 2021
3a53e40
Move style
geido May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ import { useCascadingFilters } from './state';
const FilterItem = styled.div`
min-height: ${({ theme }) => theme.gridUnit * 11}px;
padding-bottom: ${({ theme }) => theme.gridUnit * 3}px;
& > div > div {
height: auto;
}
`;

const FilterValue: React.FC<FilterProps> = ({
Expand Down
4 changes: 4 additions & 0 deletions ...board/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ const StyledDatasetContainer = styled.div`
export const StyledFormItem = styled(Form.Item)`
width: 49%;
margin-bottom: ${({ theme }) => theme.gridUnit * 4}px;

.ant-form-item-control-input-content > div > div {
height: auto;
}
`;

export const StyledCheckboxFormItem = styled(Form.Item)`
Expand Down