fix(native-filter): Default value multi-select height in native filters

[geido]

SUMMARY

Fixes the height of the multi-select for the "Default value" in the native filters modal, as well as the multi-select in the native filters left sidebar.

BEFORE

AFTER

TESTING INSTRUCTIONS

1. Open a dashboard
2. Select the filters
3. Add values in the "Default value" multi-select
4. Make sure the selected values are appearing correctly

ADDITIONAL INFORMATION

• Has associated issue: Fixes Multi-select input is obscuring other elements #14792
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[geido]

This PR is effectively overriding the fixed height that is passed to the SuperChart in superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx and superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DefaultValue.tsx. I can't really say why such height was set originally.

@rusackas seems like you have contributed to this functionality originally. Maybe you can help to answer this question.

[junlincc]

Thanks for the PR!
The reported issue is fixed, but we need to take care of the other issue "fixed height for select filter value box, so that multiple value select don't take up too much real estate in the filter bar".
just repeating myself.. I'm ok to go with the ."...+4" solution as long as the selected filter value s are at the top when expand the list. please coordinate the fix with @michael-s-molina and @villebro

Screen.Recording.2021-05-25.at.2.59.08.PM.mov

[michael-s-molina]

Thanks for the PR!
The reported issue is fixed, but we need to take care of the other issue "fixed height for select filter value box, so that multiple value select don't take up too much real estate in the filter bar".
just repeating myself.. I'm ok to go with the ."...+4" solution as long as the selected filter value s are at the top when expand the list. please coordinate the fix with @michael-s-molina and @villebro

Screen.Recording.2021-05-25.at.2.59.08.PM.mov

@geido Thanks for the fix!

@junlincc I'll add the select with +4 to my todo list. I will work on it right after we deliver the native filters revamp 😉

[villebro]

@geido this seems to need a rebase. With regard to the "...+4" feature, I'd suggest merging #14486 and following up with a new PR that moves the selected values to the top

[codecov]

Codecov Report

Merging #14816 (d246693) into master (3224e75) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d246693 differs from pull request most recent head 3a53e40. Consider uploading reports for the commit 3a53e40 to get more accurate results

@@           Coverage Diff           @@
##           master   #14816   +/-   ##
=======================================
  Coverage   77.62%   77.62%           
=======================================
  Files         963      963           
  Lines       49236    49236           
  Branches     6192     6192           
=======================================
  Hits        38217    38217           
  Misses      10819    10819           
  Partials      200      200           

Flag	Coverage Δ
javascript	72.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...veFilters/FilterBar/FilterControls/FilterValue.tsx	67.44% <ø> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	72.64% <ø> (ø)
superset/connectors/sqla/models.py	89.74% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3224e75...3a53e40. Read the comment docs.

[villebro]

LGTM and works great! I'm wondering if we could be more explicit about the > div > div but I'm fine with this!