Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Icons in "Customize Columns" in "Customize" tab break to a new line #14839

Merged
merged 1 commit into from May 28, 2021
Merged

fix(explore): Icons in "Customize Columns" in "Customize" tab break to a new line #14839

merged 1 commit into from May 28, 2021

Conversation

geido
Copy link
Member

@geido geido commented May 26, 2021

SUMMARY

Applies the style to the "Customize Columns" component and cleans up some repeated styles.

BEFORE

Screen Shot 2021-05-26 at 13 16 32

AFTER

Screen Shot 2021-05-26 at 13 16 32

TESTING INSTRUCTIONS

  1. Open a "Games" chart in Explore
  2. Visit the "Customize" tab
  3. Make sure the "Customize Columns" are not breaking into new lines

ADDITIONAL INFORMATION

  • Has associated issue: Fixes [Explore] line wrapping in column formatting menu #14831
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #14839 (3a44376) into master (d46aa60) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14839      +/-   ##
==========================================
- Coverage   77.62%   77.61%   -0.01%     
==========================================
  Files         963      963              
  Lines       49236    49239       +3     
  Branches     6192     6192              
==========================================
  Hits        38219    38219              
- Misses      10817    10820       +3     
  Partials      200      200              
Flag Coverage Δ
javascript 72.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/explore/components/ControlPanelsContainer.tsx 79.16% <0.00%> (-1.69%) ⬇️
.../src/explore/components/controls/SelectControl.jsx 89.38% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46aa60...3a44376. Read the comment docs.

@junlincc junlincc added !deprecated-label:viz:explore:others Deprecated label - Use explore instead bash! labels May 28, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the generalization makes total sense (can't think of a case where we don't want inline-block and etc for type-label), thanks for the fix!

@villebro villebro merged commit fce8ac2 into apache:master May 28, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels !deprecated-label:viz:explore:others Deprecated label - Use explore instead size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Explore] line wrapping in column formatting menu
4 participants