Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report dropdown #14852

Merged
merged 1 commit into from
May 26, 2021
Merged

Conversation

AAfghahi
Copy link
Member

SUMMARY

The Report Modal was rendering below the save screen due to an overflow issue. This corrects that. Fixes: #14802

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2021-05-26 at 2 53 56 PM

After:
Screen Shot 2021-05-26 at 2 58 35 PM

TESTING INSTRUCTIONS

Go to Alerts & Reports
Switch to reports
Click + Report
Click the dropdown under Message Content

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #14852 (d7fe9fb) into master (e466066) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14852   +/-   ##
=======================================
  Coverage   77.61%   77.61%           
=======================================
  Files         963      963           
  Lines       49246    49247    +1     
  Branches     6197     6197           
=======================================
+ Hits        38224    38225    +1     
  Misses      10821    10821           
  Partials      201      201           
Flag Coverage Δ
javascript 72.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 61.80% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e466066...d7fe9fb. Read the comment docs.

@hughhhh hughhhh self-requested a review May 26, 2021 21:17
@hughhhh hughhhh merged commit 80d22f5 into apache:master May 26, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reports Dropdown Overlapped by Toolbar
3 participants