feat(dashboard): Highlight tabs that contain a chart in scope of focused native filter #14865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14865 +/- ##
==========================================
- Coverage 77.62% 77.58% -0.05%
==========================================
Files 963 963
Lines 49236 49304 +68
Branches 6192 6213 +21
==========================================
+ Hits 38219 38252 +33
- Misses 10817 10851 +34
- Partials 200 201 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
approved these changes
May 27, 2021
| ) { | ||
| return; | ||
| } | ||
| dashboardLayout[childId].children.forEach(childId => |
There was a problem hiding this comment.
Just to avoid confusion, would it make sense to call the second childId something like subChildId?
There was a problem hiding this comment.
Nice catch, I haven't noticed that name clash. Fixed
junlincc
approved these changes
May 28, 2021
junlincc
added
dashboard:native-filters
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…sed native filter (apache#14865) * feat(dashboard): Highlight tabs that contain a chart in scope of focused native filter * Optimizations and improvements * Use Set instead of array * Simplify logic * Change variable name
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…sed native filter (apache#14865) * feat(dashboard): Highlight tabs that contain a chart in scope of focused native filter * Optimizations and improvements * Use Set instead of array * Simplify logic * Change variable name
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…sed native filter (apache#14865) * feat(dashboard): Highlight tabs that contain a chart in scope of focused native filter * Optimizations and improvements * Use Set instead of array * Simplify logic * Change variable name
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When a user focuses a native filter, tabs that contain charts in scope of that filter should get highlighted to indicate that the native filter affects contents of those tabs.
I didn't highlight active tabs as I thought it would be an overkill, since we also highlight visible charts
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-05-27.at.13.03.33.mov
TESTING INSTRUCTIONS
DASHBOARD_NATIVE_FILTERSfeature flag to trueADDITIONAL INFORMATION
CC: @villebro @junlincc @graceguo-supercat