Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump @superset-ui/legacy-preset-chart-deckgl to 0.4.7 #14871

Merged
merged 1 commit into from
May 28, 2021

Conversation

kgabryje
Copy link
Member

SUMMARY

Introduces changes implemented in apache-superset/superset-ui-plugins-deckgl#33 - DnD controls for deck.gl plugins.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See linked PR

TESTING INSTRUCTIONS

  1. Verify that deck.gl plugins work as they did before without DnD controls
  2. Set ENABLE_EXPLORE_DRAG_AND_DROP feature flag to True
  3. Verify that deck.gl plugins listed in feat(chart-controls): implement dnd controls for all charts apache-superset/superset-ui-plugins-deckgl#33 use DnD controls
  4. Verify that other charts are unaffected by changes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC: @junlincc @villebro

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #14871 (131ba54) into master (c519efe) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14871      +/-   ##
==========================================
+ Coverage   77.60%   77.62%   +0.01%     
==========================================
  Files         963      963              
  Lines       49284    49365      +81     
  Branches     6203     6214      +11     
==========================================
+ Hits        38247    38319      +72     
- Misses      10836    10845       +9     
  Partials      201      201              
Flag Coverage Δ
javascript 72.50% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/explore/components/DataTablesPane/index.tsx 86.82% <0.00%> (-2.07%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/styles.ts 97.22% <0.00%> (-0.15%) ⬇️
...ntend/src/explore/components/ExploreChartPanel.jsx 17.80% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c519efe...131ba54. Read the comment docs.

@kgabryje kgabryje closed this May 27, 2021
@kgabryje kgabryje reopened this May 27, 2021
Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as product sign-off!

@kgabryje kgabryje merged commit 507d4d7 into apache:master May 28, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants