fix(docker/helm): Make webserver query timeout adjustable #15007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielewood
changed the title
amitmiran137
approved these changes
Jun 16, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* Allow timeout override, but keep default if unset * Add template placeholder values for timeout change * Bump chart version * linting * remove whitespace
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* Allow timeout override, but keep default if unset * Add template placeholder values for timeout change * Bump chart version * linting * remove whitespace
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* Allow timeout override, but keep default if unset * Add template placeholder values for timeout change * Bump chart version * linting * remove whitespace
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We have long running dashboard queries (2-3 minutes) which were getting tripped up by the 60 second timeout with 504 Gateway Timeout.
I modified the dockerfile to keep the default 60 second timeout on gunicorn, but allow GUNICORN_TIMEOUT env to override.
I also modified the values.yml to provide the needed placeholders to implementing a longer timeout at gunicorn, superset_webserver_timeout, and the nginx proxy timeout.
Note: This change is non-disruptive, no end user will be impacted unless they turn on settings in the values.yaml.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION