New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: spinner for imports #15055
feat: spinner for imports #15055
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15055 +/- ##
==========================================
- Coverage 77.76% 77.75% -0.01%
==========================================
Files 966 966
Lines 49628 49640 +12
Branches 6314 6320 +6
==========================================
+ Hits 38591 38598 +7
- Misses 10836 10840 +4
- Partials 201 202 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Wondering why we're hiding the context while the spinner is active context? We have a fair amount of "modal resizing" in the product currently (as dynamic content changes the height of the context) and it generally looks jittery. Keeping the context would prevent that. Side note: can we re-style the button too? I know these file buttons are funky to style sometimes, but if we take over with an antd component maybe we can just disable the button while the spinner is active? |
@mistercrunch I opted to hide the content because if we don't resize the modal the spinner was showing up on top of the filename, which was ugly.
I wrote this last night: #15057 |
6e7c442
to
7a1ce97
Compare
* Update tests * feat: spinner for imports * Use loading button instead * Small fixes * Small fix
* Update tests * feat: spinner for imports * Use loading button instead * Small fixes * Small fix
* Update tests * feat: spinner for imports * Use loading button instead * Small fixes * Small fix
SUMMARY
Show a spinner during the import process.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
spinner_import.mov
TESTING INSTRUCTIONS
I modified the import API endpoint to sleep for 5 seconds, and imported a databaset.
ADDITIONAL INFORMATION