feat: style import button #15057
feat: style import button #15057
Conversation
|
ooh loving how the file name looks after it's selected! |
| @@ -16,10 +16,13 @@ | |||
| * specific language governing permissions and limitations | |||
| * under the License. | |||
| */ | |||
| import React, { FunctionComponent, useEffect, useRef, useState } from 'react'; | |||
| import React, { FunctionComponent, useEffect, useState } from 'react'; | |||
| import { Upload } from 'antd'; | |||
There was a problem hiding this comment.
A few of us were just talking about antd imports the other day. Do you mind importing and exporting this component in the /superset-frontend/src/common/components/index.tsx file and pulling it in from there? We're going to try to clean all these up at some point for consistency.
There was a problem hiding this comment.
Yeah, I like having that abstraction layer for the day we move from antd to the new fancy component library. Will move.
|
thanks for the improvement! is there any validation for invalid upload?
|
There is, the backend does a variety of validations, including:
|
Codecov Report
@@ Coverage Diff @@
## master #15057 +/- ##
==========================================
- Coverage 77.76% 77.75% -0.01%
==========================================
Files 966 966
Lines 49628 49631 +3
Branches 6314 6312 -2
==========================================
+ Hits 38591 38593 +2
- Misses 10836 10837 +1
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* feat: style import button * Update tests * Update test
* feat: style import button * Update tests * Update test
* feat: style import button * Update tests * Update test
mistercrunch
added
🏷️ bot
SUMMARY
Use the antd
Uploadcomponent when importing models. This allows us to style the button and have slightly better UX.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
style_import_button.mov
@yousoph @Steejay what do you think of the new modal?
TESTING INSTRUCTIONS
Imported database manually.
ADDITIONAL INFORMATION