Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dnd): add isExtra prop to Option #15080

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Jun 10, 2021

SUMMARY

The Drag and drop option was missing the isExtra prop, causing the warning triangle to be missing when exploring a chart with extra filters.

BEFORE

image

AFTER

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #15080 (8167c03) into master (9967a5f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15080      +/-   ##
==========================================
+ Coverage   77.78%   77.81%   +0.02%     
==========================================
  Files         966      967       +1     
  Lines       49629    49672      +43     
  Branches     6314     6328      +14     
==========================================
+ Hits        38606    38652      +46     
+ Misses      10822    10819       -3     
  Partials      201      201              
Flag Coverage Δ
javascript 72.85% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontrols/DndColumnSelectControl/DndFilterSelect.tsx 45.38% <ø> (ø)
.../controls/DndColumnSelectControl/OptionWrapper.tsx 84.84% <ø> (ø)
...ponents/controls/DndColumnSelectControl/Option.tsx 100.00% <100.00%> (ø)
...-frontend/src/datasource/ChangeDatasourceModal.tsx 87.35% <0.00%> (-3.56%) ⬇️
...rset-frontend/src/components/ImportModal/index.tsx 69.79% <0.00%> (-1.64%) ⬇️
...et-frontend/src/components/TableView/TableView.tsx 96.96% <0.00%> (-1.25%) ⬇️
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 70.18% <0.00%> (-0.37%) ⬇️
...rontend/src/SqlLab/components/QueryTable/index.jsx 61.33% <0.00%> (-0.32%) ⬇️
superset-frontend/src/common/components/index.tsx 100.00% <0.00%> (ø)
superset-frontend/src/components/Button/index.tsx 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9967a5f...8167c03. Read the comment docs.

@villebro villebro merged commit 65714cc into apache:master Jun 10, 2021
@villebro villebro deleted the villebro/dnd-isExtra branch June 10, 2021 09:13
@junlincc junlincc added the explore:drag&drop Related to drag&drop in Explore label Jun 10, 2021
@junlincc
Copy link
Member

closes #15106

@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Jun 10, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard explore:drag&drop Related to drag&drop in Explore preset-io size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
4 participants