-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improves the native filters bar layout #15115
chore: Improves the native filters bar layout #15115
Conversation
213943e
to
a85f870
Compare
Codecov Report
@@ Coverage Diff @@
## master #15115 +/- ##
==========================================
- Coverage 77.25% 77.18% -0.08%
==========================================
Files 969 969
Lines 49999 50042 +43
Branches 6424 6438 +14
==========================================
- Hits 38629 38625 -4
- Misses 11167 11214 +47
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Wow, that looks SO much better than before! Thanks for that change. Could we move the "expand" icon up when filters are collapsed? I don't think it should change it's position that much compared to when the filter bar is expanded |
a85f870
to
574a801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - what an incredible improvement to the native filter experience! 🎉
SUMMARY
Improves the native filters bar layout.
Fixes #14973
Fixes #15002
@villebro @rusackas @kgabryje @junlincc
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
screen-recording-2021-06-11-at-72640-am_ifDlD0KH.mov
screen-recording-2021-06-11-at-73023-am_KxzcQ29x.mov
TESTING INSTRUCTIONS
See before/after videos for instructions.
ADDITIONAL INFORMATION