New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve dashboard fullscreen text #15139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except for CI. LGTM
I format the code. need a approval again. |
Codecov Report
@@ Coverage Diff @@
## master #15139 +/- ##
==========================================
- Coverage 77.49% 77.49% -0.01%
==========================================
Files 969 969
Lines 49902 49905 +3
Branches 6383 6386 +3
==========================================
+ Hits 38671 38672 +1
- Misses 11029 11030 +1
- Partials 202 203 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
Semantic name from
toggle fullscreen
toEnter fullscreen
andExit fullscreen
.BEFORE/AFTER ANIMATED GIF
before
after
TESTING INSTRUCTIONS
Enter fullscreen
Exit fullscreen
to toggle back to normal screenADDITIONAL INFORMATION
issue: #15110