Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve dashboard fullscreen text #15139

Merged
merged 3 commits into from Jun 14, 2021

Conversation

xiezhongfu
Copy link
Contributor

SUMMARY

Semantic name from toggle fullscreen to Enter fullscreen and Exit fullscreen.

BEFORE/AFTER ANIMATED GIF

before
toggle fullscreen2

after
toggle fullscreen

TESTING INSTRUCTIONS

  • Go to dashboard 3 dot menu, click Enter fullscreen
  • After dashboard become fullscreen, click on 3 dot menu again
  • Observe the last option Exit fullscreen to toggle back to normal screen

ADDITIONAL INFORMATION

issue: #15110

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for CI. LGTM

@zhaoyongjie zhaoyongjie changed the title fix: improve the semantics of toggle fullscreen menu fix: improve dashboard fullscreen text Jun 13, 2021
@xiezhongfu
Copy link
Contributor Author

except for CI. LGTM

I format the code. need a approval again.

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #15139 (ddcf0b5) into master (856a2bd) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head ddcf0b5 differs from pull request most recent head 2d1e973. Consider uploading reports for the commit 2d1e973 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15139      +/-   ##
==========================================
- Coverage   77.49%   77.49%   -0.01%     
==========================================
  Files         969      969              
  Lines       49902    49905       +3     
  Branches     6383     6386       +3     
==========================================
+ Hits        38671    38672       +1     
- Misses      11029    11030       +1     
- Partials      202      203       +1     
Flag Coverage Δ
javascript 72.37% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/Header/HeaderActionsDropdown/index.jsx 67.08% <33.33%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856a2bd...2d1e973. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 57035c1 into apache:master Jun 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants