Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disable comment logging for ephemeral envs #15156

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

robdiciuccio
Copy link
Member

@robdiciuccio robdiciuccio commented Jun 14, 2021

SUMMARY

Cleanup action logging by removing comment body. Also adds Preset engineers (committers) to CODEOWNERS for ephemeral env workflows.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@robdiciuccio robdiciuccio merged commit 7a21f9a into apache:master Jun 14, 2021
@robdiciuccio robdiciuccio deleted the rd/ephemeral-env-logging branch June 14, 2021 21:31
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* Disable comment logging

* Update CODEOWNERS
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* Disable comment logging

* Update CODEOWNERS
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* Disable comment logging

* Update CODEOWNERS
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants