Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allows the user to force fetch the default values #15178

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Allows the user to force fetch the default values.

Fixes #14791

@rusackas @villebro @kgabryje @junlincc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-06-15.at.4.14.01.PM.mov

TESTING INSTRUCTIONS

1 - Go to the native filters modal
2 - Expand the default value
3 - Check the available values
4 - Modify the values on the database
5 - Hit the refresh icon
6 - Check that the available values changed

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #15178 (5be45df) into master (9ba2983) will decrease coverage by 0.01%.
The diff coverage is 20.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15178      +/-   ##
==========================================
- Coverage   77.25%   77.24%   -0.02%     
==========================================
  Files         969      969              
  Lines       49999    50019      +20     
  Branches     6424     6431       +7     
==========================================
+ Hits        38629    38638       +9     
- Misses      11167    11178      +11     
  Partials      203      203              
Flag Coverage Δ
javascript 72.21% <20.58%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx 25.00% <ø> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 68.33% <20.58%> (-1.74%) ⬇️
...ols/DateFilterControl/components/CalendarFrame.tsx 42.85% <0.00%> (-3.30%) ⬇️
...nd/src/dashboard/components/nativeFilters/utils.ts 56.25% <0.00%> (ø)
.../src/dashboard/components/gridComponents/Chart.jsx 85.04% <0.00%> (ø)
...mponents/nativeFilters/FiltersConfigModal/utils.ts 66.25% <0.00%> (ø)
...tersConfigModal/FiltersConfigForm/ColumnSelect.tsx 97.36% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba2983...5be45df. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit 4289929 into apache:master Jun 16, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native filter] filter component can not force refresh options
3 participants