Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changes the dashboard highlight color when selecting a filter #15192

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Changes the dashboard highlight color when selecting a filter

@rusackas @villebro @kgabryje @junlincc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-06-16.at.8.29.27.AM.mov
Screen.Recording.2021-06-16.at.8.24.54.AM.mov

TESTING INSTRUCTIONS

See before/after videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #15192 (6ce30bc) into master (4289929) will not change coverage.
The diff coverage is n/a.

❗ Current head 6ce30bc differs from pull request most recent head a537181. Consider uploading reports for the commit a537181 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15192   +/-   ##
=======================================
  Coverage   77.18%   77.18%           
=======================================
  Files         969      969           
  Lines       50070    50070           
  Branches     6439     6439           
=======================================
  Hits        38645    38645           
  Misses      11220    11220           
  Partials      205      205           
Flag Coverage Δ
javascript 72.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ashboard/components/gridComponents/ChartHolder.jsx 74.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4289929...a537181. Read the comment docs.

@villebro villebro requested a review from kgabryje June 16, 2021 13:03
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgabryje kgabryje merged commit dafaaae into apache:master Jun 16, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants