Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move SupersetAppInitializer to specific initialization package #15278

Conversation

ofekisr
Copy link
Contributor

@ofekisr ofekisr commented Jun 21, 2021

SUMMARY

move SupersetAppInitializer from app.py to initialization package to achieve separation of concerns

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #15278 (b70407c) into master (b1689aa) will decrease coverage by 0.22%.
The diff coverage is 88.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15278      +/-   ##
==========================================
- Coverage   77.24%   77.01%   -0.23%     
==========================================
  Files         972      973       +1     
  Lines       50366    50371       +5     
  Branches     6140     6140              
==========================================
- Hits        38905    38794     -111     
- Misses      11257    11373     +116     
  Partials      204      204              
Flag Coverage Δ
hive ?
mysql 81.66% <88.38%> (+<0.01%) ⬆️
postgres 81.68% <88.38%> (+<0.01%) ⬆️
presto ?
python 81.77% <88.38%> (-0.44%) ⬇️
sqlite 81.31% <88.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/initialization/__init__.py 88.30% <88.30%> (ø)
superset/app.py 81.25% <100.00%> (-6.44%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.20% <0.00%> (-17.21%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.53%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.22% <0.00%> (-1.65%) ⬇️
superset/db_engine_specs/base.py 87.97% <0.00%> (-0.41%) ⬇️
superset/models/core.py 89.76% <0.00%> (-0.27%) ⬇️
superset/utils/core.py 88.93% <0.00%> (-0.13%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1689aa...b70407c. Read the comment docs.

Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear separation between the create_app function to the ApplicationInitiator class

@amitmiran137 amitmiran137 merged commit 2792ddc into apache:master Jun 21, 2021
@amitmiran137 amitmiran137 deleted the chore/move_app_initializer_to_other_file branch June 21, 2021 10:22
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants