Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: icon to icons in erroralert component #15341

Merged
merged 5 commits into from
Jun 25, 2021

Conversation

pkdotson
Copy link
Member

SUMMARY

This pr migrates the old icon to icons in erroralert component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
The query returned no data
Control labeled Columns cannot be empty
Database error

after
The query returned no data
Database error
Control labeled Columns cannot be empty

TESTING INSTRUCTIONS

Tes in exploreview in chart, and sql lab query and result view tabs

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #15341 (82d13d9) into master (a330b66) will decrease coverage by 0.06%.
The diff coverage is 87.37%.

❗ Current head 82d13d9 differs from pull request most recent head 28ef212. Consider uploading reports for the commit 28ef212 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15341      +/-   ##
==========================================
- Coverage   77.24%   77.17%   -0.07%     
==========================================
  Files         973      975       +2     
  Lines       50523    50586      +63     
  Branches     6184     6204      +20     
==========================================
+ Hits        39025    39040      +15     
- Misses      11292    11339      +47     
- Partials      206      207       +1     
Flag Coverage Δ
javascript 71.79% <86.81%> (+0.02%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/common/hooks/useComponentDidUpdate/index.ts 0.00% <0.00%> (ø)
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
...ilterScopingModal/CrossFilterScopingForm/index.tsx 84.61% <ø> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 74.59% <ø> (ø)
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx 65.68% <0.00%> (ø)
superset-frontend/src/setup/setupErrorMessages.ts 0.00% <0.00%> (ø)
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 70.05% <ø> (ø)
...ConfigModal/FiltersConfigForm/FilterScope/state.ts 95.65% <66.66%> (-4.35%) ⬇️
superset/viz.py 56.52% <66.66%> (+0.05%) ⬆️
...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx 90.62% <80.00%> (-5.03%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a330b66...28ef212. Read the comment docs.

@pkdotson pkdotson merged commit a3f4e4a into apache:master Jun 25, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* initial commit

* initial commit

* lint
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* initial commit

* initial commit

* lint
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* initial commit

* initial commit

* lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants