-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: icon to icons in erroralert component #15341
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15341 +/- ##
==========================================
- Coverage 77.24% 77.17% -0.07%
==========================================
Files 973 975 +2
Lines 50523 50586 +63
Branches 6184 6204 +20
==========================================
+ Hits 39025 39040 +15
- Misses 11292 11339 +47
- Partials 206 207 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* initial commit * initial commit * lint
* initial commit * initial commit * lint
* initial commit * initial commit * lint
SUMMARY
This pr migrates the old icon to icons in erroralert component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
![The query returned no data](https://user-images.githubusercontent.com/17326228/123182544-8b029900-d444-11eb-99f1-97af50194780.png)
![Control labeled Columns cannot be empty](https://user-images.githubusercontent.com/17326228/123182547-8d64f300-d444-11eb-8f6b-e076632e9019.png)
![Database error](https://user-images.githubusercontent.com/17326228/123182552-905fe380-d444-11eb-958a-3ee2ac191f37.png)
after
![The query returned no data](https://user-images.githubusercontent.com/17326228/123182606-ab325800-d444-11eb-9df3-718f1b6b6ffd.png)
![Database error](https://user-images.githubusercontent.com/17326228/123182611-ad94b200-d444-11eb-93ae-dca9006b168c.png)
![Control labeled Columns cannot be empty](https://user-images.githubusercontent.com/17326228/123182616-b08fa280-d444-11eb-8b81-73456aff0dfa.png)
TESTING INSTRUCTIONS
Tes in exploreview in chart, and sql lab query and result view tabs
ADDITIONAL INFORMATION