Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(native-filters): remove instant filtering option #15365

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

villebro
Copy link
Member

SUMMARY

This PR removes support for instant filtering from native filters. Primary motivations for the removal are as follows:

  • performance implications of triggering filters with every change
  • problems associated with mixing both instant and non-instant filters

AFTER

Notice the absence of instant filtering options.
image

BEFORE

Notice the control "Apply changes instantly":
image

TESTING INSTRUCTIONS

Local testing + updated tests

ADDITIONAL INFORMATION

  • Has associated issue: closes [native-filters*1]Multiple dashboard native filter UX improvement  #15067
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro force-pushed the villebro/remove-instant-filtering branch 2 times, most recently from 6e8052e to bdeff92 Compare June 25, 2021 07:07
@villebro villebro force-pushed the villebro/remove-instant-filtering branch from bdeff92 to 17d6f89 Compare July 1, 2021 09:37
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #15365 (2ffdbcf) into master (e606477) will increase coverage by 0.04%.
The diff coverage is 50.00%.

❗ Current head 2ffdbcf differs from pull request most recent head 17d6f89. Consider uploading reports for the commit 17d6f89 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15365      +/-   ##
==========================================
+ Coverage   77.20%   77.24%   +0.04%     
==========================================
  Files         975      975              
  Lines       50842    50833       -9     
  Branches     6728     6722       -6     
==========================================
+ Hits        39251    39266      +15     
+ Misses      11376    11351      -25     
- Partials      215      216       +1     
Flag Coverage Δ
javascript 71.85% <50.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/nativeFilters/FiltersConfigModal/utils.ts 72.60% <ø> (+5.10%) ⬆️
...board/components/nativeFilters/FilterBar/index.tsx 83.17% <33.33%> (-1.09%) ⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 72.40% <100.00%> (+2.87%) ⬆️
superset-frontend/src/dataMask/actions.ts 42.85% <0.00%> (-35.72%) ⬇️
superset-frontend/src/dataMask/reducer.ts 65.30% <0.00%> (-6.13%) ⬇️
...odal/FiltersConfigForm/FilterScope/FilterScope.tsx 91.11% <0.00%> (+2.22%) ⬆️
...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx 93.75% <0.00%> (+3.12%) ⬆️
...nts/controls/DateFilterControl/DateFilterLabel.tsx 66.66% <0.00%> (+8.94%) ⬆️
...nd/src/components/SupersetResourceSelect/index.tsx 83.87% <0.00%> (+12.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e606477...17d6f89. Read the comment docs.

@villebro villebro merged commit f286647 into apache:master Jul 1, 2021
@villebro villebro deleted the villebro/remove-instant-filtering branch July 1, 2021 10:39
amitmiran137 pushed a commit that referenced this pull request Jul 4, 2021
* chore(native-filters): remove instant filtering option

* fix test

(cherry picked from commit f286647)
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* chore(native-filters): remove instant filtering option

* fix test
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* chore(native-filters): remove instant filtering option

* fix test
@saultawil
Copy link

Are there any plan to add back this feature? - I really miss it and other BI tools have it.

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* chore(native-filters): remove instant filtering option

* fix test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M v1.3 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native-filters*1]Multiple dashboard native filter UX improvement
5 participants