-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(native-filters): remove instant filtering option #15365
chore(native-filters): remove instant filtering option #15365
Conversation
6e8052e
to
bdeff92
Compare
bdeff92
to
17d6f89
Compare
Codecov Report
@@ Coverage Diff @@
## master #15365 +/- ##
==========================================
+ Coverage 77.20% 77.24% +0.04%
==========================================
Files 975 975
Lines 50842 50833 -9
Branches 6728 6722 -6
==========================================
+ Hits 39251 39266 +15
+ Misses 11376 11351 -25
- Partials 215 216 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* chore(native-filters): remove instant filtering option * fix test (cherry picked from commit f286647)
* chore(native-filters): remove instant filtering option * fix test
* chore(native-filters): remove instant filtering option * fix test
Are there any plan to add back this feature? - I really miss it and other BI tools have it. |
* chore(native-filters): remove instant filtering option * fix test
SUMMARY
This PR removes support for instant filtering from native filters. Primary motivations for the removal are as follows:
AFTER
Notice the absence of instant filtering options.
BEFORE
Notice the control "Apply changes instantly":
TESTING INSTRUCTIONS
Local testing + updated tests
ADDITIONAL INFORMATION