fix(native-filters): show human readable time grain label in indicator #15411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15411 +/- ##
==========================================
- Coverage 77.22% 77.22% -0.01%
==========================================
Files 975 975
Lines 50634 50638 +4
Branches 6222 6223 +1
==========================================
Hits 39104 39104
- Misses 11319 11323 +4
Partials 211 211
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
simcha90
reviewed
Jun 28, 2021
superset-frontend/src/filters/components/TimeGrain/TimeGrainFilterPlugin.tsx
Show resolved
Hide resolved
simcha90
approved these changes
Jun 28, 2021
villebro
force-pushed
the
villebro/timegrain-label
branch
from
6d70c1d
to
a11c2e4
Compare
mvoitko
pushed a commit
to mvoitko/superset
that referenced
this pull request
Jun 28, 2021
apache#15411) * fix(native-filters): show human readable time grain label in indicator * lint * simplify
|
🏷 2021.25 |
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Jun 28, 2021
apache#15411) * fix(native-filters): show human readable time grain label in indicator * lint * simplify (cherry picked from commit ddcf461)
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
apache#15411) * fix(native-filters): show human readable time grain label in indicator * lint * simplify
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
apache#15411) * fix(native-filters): show human readable time grain label in indicator * lint * simplify
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
apache#15411) * fix(native-filters): show human readable time grain label in indicator * lint * simplify
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently when using a time grain native filter, the ISO-8601 time duration is shown in the filter indicator. Instead of showing the technical duration in the indicator (e.g.
PT1H), it is preferable to show the human readable filter value (e.g. "Hour").AFTER
Now the human readable label is displayed in the filter indicator:
BEFORE
Previously the ISO-8601 time duration was shown in the filter indicator
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION