Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): Fix clear all button #15438

Merged
merged 19 commits into from
Jun 30, 2021
Merged

Conversation

simcha90
Copy link
Contributor

@simcha90 simcha90 commented Jun 29, 2021

SUMMARY

Fix for: #15361

When user clicks Clear All we now update redux instead of local state

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: closes [native filter] 'Clear All' will show error in value filter  #15361
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@simcha90 simcha90 closed this Jun 29, 2021
@simcha90 simcha90 reopened this Jun 29, 2021
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #15438 (1b6bebf) into master (ed6d10e) will increase coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15438      +/-   ##
==========================================
+ Coverage   77.21%   77.23%   +0.02%     
==========================================
  Files         975      974       -1     
  Lines       50662    50753      +91     
  Branches     6228     6728     +500     
==========================================
+ Hits        39120    39201      +81     
- Misses      11331    11337       +6     
- Partials      211      215       +4     
Flag Coverage Δ
javascript 71.77% <50.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/nativeFilters/FilterBar/Header/index.tsx 90.00% <42.85%> (-1.90%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 84.25% <100.00%> (-6.17%) ⬇️
...nd/src/dashboard/components/FiltersBadge/index.tsx 86.90% <0.00%> (-13.10%) ⬇️
superset-frontend/src/utils/urlUtils.ts 45.94% <0.00%> (-7.39%) ⬇️
...ters/FiltersConfigModal/FiltersConfigForm/utils.ts 88.88% <0.00%> (-3.42%) ⬇️
superset-frontend/src/constants.ts 100.00% <0.00%> (ø)
superset-frontend/src/views/CRUD/hooks.ts 52.80% <0.00%> (ø)
superset-frontend/src/setup/setupColors.ts 86.66% <0.00%> (ø)
superset-frontend/src/components/Icons/index.tsx 100.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed6d10e...1b6bebf. Read the comment docs.

@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Jun 29, 2021
@junlincc junlincc requested review from suddjian and geido June 29, 2021 17:04
@villebro villebro self-requested a review June 30, 2021 06:16
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested to work with one small nit.

simcha90 and others added 2 commits June 30, 2021 14:09
…rBar/Header/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@villebro villebro merged commit 5f96e63 into apache:master Jun 30, 2021
amitmiran137 pushed a commit that referenced this pull request Jul 4, 2021
* fix:fix get permission function

* fix: "clear all" async flow

* lint: fix lint

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* lint: fix lint

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
(cherry picked from commit 5f96e63)
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* fix:fix get permission function

* fix: "clear all" async flow

* lint: fix lint

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* lint: fix lint

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix:fix get permission function

* fix: "clear all" async flow

* lint: fix lint

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* lint: fix lint

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix:fix get permission function

* fix: "clear all" async flow

* lint: fix lint

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* lint: fix lint

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard size/M v1.3 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native filter] 'Clear All' will show error in value filter
5 participants