Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more SIP-40 errors #15482

Merged
merged 1 commit into from Jun 30, 2021
Merged

feat: more SIP-40 errors #15482

merged 1 commit into from Jun 30, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

Make more SQL Lab error message SIP-40 compliant.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #15482 (b980f81) into master (5181a74) will decrease coverage by 0.27%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15482      +/-   ##
==========================================
- Coverage   77.24%   76.96%   -0.28%     
==========================================
  Files         974      975       +1     
  Lines       50782    50842      +60     
  Branches     6256     6728     +472     
==========================================
- Hits        39226    39133      -93     
- Misses      11343    11494     +151     
- Partials      213      215       +2     
Flag Coverage Δ
hive ?
javascript 71.76% <0.00%> (-0.01%) ⬇️
mysql 81.64% <36.36%> (-0.10%) ⬇️
postgres 81.66% <36.36%> (-0.10%) ⬇️
presto ?
python 81.74% <36.36%> (-0.53%) ⬇️
sqlite 81.28% <36.36%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
superset-frontend/src/setup/setupErrorMessages.ts 0.00% <0.00%> (ø)
superset/views/core.py 75.12% <17.64%> (-0.42%) ⬇️
superset/errors.py 100.00% <100.00%> (ø)
superset/exceptions.py 93.02% <100.00%> (+2.54%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/trino.py 59.72% <0.00%> (-35.02%) ⬇️
superset/db_engine_specs/hive.py 69.20% <0.00%> (-17.21%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.53%) ⬇️
superset/connectors/connector_registry.py 78.68% <0.00%> (-4.65%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5181a74...b980f81. Read the comment docs.

@betodealmeida betodealmeida merged commit e606477 into apache:master Jun 30, 2021
graceguo-supercat pushed a commit to airbnb/superset-fork that referenced this pull request Jul 8, 2021
@graceguo-supercat
Copy link

Hi @betodealmeida this PR cause Sql Lab can not handle some error message correctly:

Screen Shot 2021-07-08 at 12 33 19 PM

I have reverted this from airbnb's release branch, but you probably have to fix it in open source master branch.

john-bodley added a commit to airbnb/superset-fork that referenced this pull request Jul 14, 2021
ktmud pushed a commit to airbnb/superset-fork that referenced this pull request Jul 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants