fix(15482): Propagate SupersetSecurityException error

[john-bodley]

SUMMARY

I'm not sure why in #15482 we construct a new SupersetError (with corresponding message, error type, and level) rather than merely leveraging the mandatory SupersetError which raised as part of the SupersetSecurityException.

These errors contain specifics (message, error type, etc.) which differ depending on the type of exception (example)—which also may be custom for security manager overrides—and thus should be preserved.

This PR merely uses the previous SupersetError (which is guaranteed to exist per the SupersetSecurityException signature) rather than constructing a new error.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[etr2460]

lgtm, cc @betodealmeida

[codecov]

Codecov Report

Merging #15874 (964ac51) into master (f9b7250) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

❗ Current head 964ac51 differs from pull request most recent head 6e16019. Consider uploading reports for the commit 6e16019 to get more accurate results

@@            Coverage Diff             @@
##           master   #15874      +/-   ##
==========================================
- Coverage   77.08%   76.95%   -0.13%     
==========================================
  Files         984      984              
  Lines       51787    51784       -3     
  Branches     7031     7031              
==========================================
- Hits        39918    39851      -67     
- Misses      11644    11708      +64     
  Partials      225      225              

Flag	Coverage Δ
hive	?
mysql	81.54% <0.00%> (+<0.01%)	⬆️
postgres	81.56% <0.00%> (+<0.01%)	⬆️
presto	81.30% <0.00%> (+0.01%)	⬆️
python	81.84% <0.00%> (-0.25%)	⬇️
sqlite	81.20% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/core.py	75.21% <0.00%> (+0.16%)	⬆️
superset/db_engines/hive.py	0.00% <0.00%> (-82.15%)	⬇️
superset/db_engine_specs/hive.py	69.44% <0.00%> (-17.07%)	⬇️
superset/connectors/sqla/models.py	89.71% <0.00%> (-0.24%)	⬇️
superset/utils/core.py	88.12% <0.00%> (-0.13%)	⬇️
superset/db_engine_specs/presto.py	90.31% <0.00%> (+0.42%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b7250...6e16019. Read the comment docs.