Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "chore: Bump @svgr/webpack to 5.5.0" #15508

Closed
wants to merge 1 commit into from

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Jul 1, 2021

Reverts #15349

This upgrade was causing other dependency issues. We still need to address it, but want to unblock things for now.

More PRs/discussion around this upgrade, and others, coming soon...

@kgabryje kgabryje changed the title Revert "chore: Bump @svgr/webpack to 5.5.0" fix: Revert "chore: Bump @svgr/webpack to 5.5.0" Jul 1, 2021
@kgabryje kgabryje closed this Jul 1, 2021
@kgabryje kgabryje reopened this Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #15508 (53657f9) into master (7889564) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15508      +/-   ##
==========================================
- Coverage   77.16%   77.15%   -0.01%     
==========================================
  Files         975      975              
  Lines       50865    50874       +9     
  Branches     6740     6740              
==========================================
+ Hits        39251    39253       +2     
- Misses      11398    11405       +7     
  Partials      216      216              
Flag Coverage Δ
hive 81.38% <ø> (ø)
javascript 71.84% <ø> (-0.02%) ⬇️
mysql 81.64% <ø> (ø)
postgres 81.66% <ø> (ø)
python 82.04% <ø> (ø)
sqlite 81.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../nativeFilters/FilterBar/FilterSets/utils/index.ts 96.15% <0.00%> (-3.85%) ⬇️
...et-frontend/src/dashboard/actions/nativeFilters.ts 50.84% <0.00%> (-2.73%) ⬇️
...ters/FiltersConfigModal/FiltersConfigForm/utils.ts 86.20% <0.00%> (-2.69%) ⬇️
superset-frontend/src/common/components/index.tsx 98.03% <0.00%> (-1.97%) ⬇️
...nts/controls/DateFilterControl/utils/dateParser.ts 96.15% <0.00%> (-1.25%) ⬇️
superset-frontend/src/components/Select/Select.tsx 0.00% <0.00%> (ø)
...et-frontend/src/dashboard/actions/dashboardInfo.ts 47.05% <0.00%> (ø)
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 61.80% <0.00%> (ø)
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 76.92% <0.00%> (ø)
...tend/src/views/CRUD/annotation/AnnotationModal.tsx 62.96% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7889564...53657f9. Read the comment docs.

@graceguo-supercat
Copy link

thank you @rusackas!

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat
Copy link

ping @rusackas could you resolve conflicts and merge this PR? thanks!

@rusackas
Copy link
Member Author

rusackas commented Jul 8, 2021

Ugly rebase... will open a new revert. Sorry, thought this was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants