Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump @svgr/webpack to 5.5.0 #15349

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Conversation

kgabryje
Copy link
Member

SUMMARY

Bumps @svgr/webpack from ^5.4.0 to ^5.5.0

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #15349 (3c51ba5) into master (b89ee0c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15349   +/-   ##
=======================================
  Coverage   77.23%   77.23%           
=======================================
  Files         973      973           
  Lines       50491    50487    -4     
  Branches     6184     6183    -1     
=======================================
- Hits        38997    38996    -1     
+ Misses      11288    11285    -3     
  Partials      206      206           
Flag Coverage Δ
javascript 71.78% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/CRUD/hooks.ts 52.80% <0.00%> (-0.22%) ⬇️
superset-frontend/src/setup/setupErrorMessages.ts 0.00% <0.00%> (ø)
superset-frontend/src/components/Select/Select.tsx 0.00% <0.00%> (ø)
...et-frontend/src/components/CertifiedIcon/index.tsx 100.00% <0.00%> (ø)
...et-frontend/src/dashboard/actions/dashboardInfo.ts 47.05% <0.00%> (ø)
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 61.80% <0.00%> (ø)
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 76.92% <0.00%> (ø)
...tend/src/views/CRUD/annotation/AnnotationModal.tsx 62.96% <0.00%> (ø)
.../src/views/CRUD/data/savedquery/SavedQueryList.tsx 72.91% <0.00%> (ø)
...src/filters/components/Range/RangeFilterPlugin.tsx 90.90% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89ee0c...3c51ba5. Read the comment docs.

@rusackas rusackas merged commit 53aa351 into apache:master Jun 25, 2021
michellethomas pushed a commit to airbnb/superset-fork that referenced this pull request Jun 30, 2021
michellethomas pushed a commit to airbnb/superset-fork that referenced this pull request Jun 30, 2021
@graceguo-supercat
Copy link

graceguo-supercat commented Jun 30, 2021

Hi @kgabryje, we saw some errors when we tried to deploy latest master branch to airbnb production. the error is like

[2021-06-30T01:15:09Z] [Jun 30 01:15:09]  INFO ==>  ERROR in ./src/showSavedQuery/index.jsx
--
  | [2021-06-30T01:15:09Z] [Jun 30 01:15:09]  INFO ==>  Module build failed (from ./node_modules/babel-loader/lib/index.js):
  | [2021-06-30T01:15:09Z] [Jun 30 01:15:09]  INFO ==>  Error: Cannot find module '@emotion/babel-plugin-jsx-pragmatic'
  | [2021-06-30T01:15:09Z] [Jun 30 01:15:09]  INFO ==>  Require stack:
  | [2021-06-30T01:15:09Z] [Jun 30 01:15:09]  INFO ==>  - /srv/superset-internal/superset-fork/superset-frontend/node_modules/@emotion/babel-preset-css-prop/dist/emotion-babel-preset-css-prop.cjs.prod.js
  | [2021-06-30T01:15:09Z] [Jun 30 01:15:09]  INFO ==>  - /srv/superset-internal/superset-fork/superset-frontend/node_modules/@emotion/babel-preset-css-prop/dist/emotion-babel-preset-css-prop.cjs.js
  | [2021-06-30T01:15:09Z] [Jun 30 01:15:09]  INFO ==>  - /srv/superset-internal/superset-fork/superset-frontend/node_modules/@babel/core/lib/config/files/plugins.js
  | [2021-06-30T01:15:09Z] [Jun 30 01:15:09]  INFO ==>  - /srv/superset-internal/superset-fork/superset-frontend/node_modules/@babel/core/lib/config/files/index.js
...

we used npm version 7.12. If we revert this PR then build successful. Do you know anyway to fix above error? Why do we need this webpack upgrade? thanks!

cc @michellethomas @john-bodley

@nytai
Copy link
Member

nytai commented Jun 30, 2021

pretty sure this upgrade was due to a security vulnerability in the current installed version. Looks like the issue is missing dependency@emotion/babel-plugin-jsx-pragmatic, we can probably just add that dependency and it should work.

@kgabryje
Copy link
Member Author

kgabryje commented Jul 1, 2021

Yes, I bumped that version to fix a vulnerability reported by dependabot. That error is surprising since the build on CI has passed... and I can't see showSavedQuery/index.js being used anywhere. Anyways, I opened a PR which adds the missing dependency: #15491. I'd appreciate it if you took a look

@kgabryje
Copy link
Member Author

kgabryje commented Jul 1, 2021

Adding @emotion/babel-plugin-jsx-pragmatic triggered multiple build errors on CI, which seem unrelated. I think debugging that might not be trivial, so for now I'd propose reverting this PR and revisiting the issue later.

@rusackas
Copy link
Member

rusackas commented Jul 1, 2021

I agree that reverting this for now is probably the right approach if it's causing pain, and we can re-address it in a new PR or series of PRs. I fear that many issues of this type are indicating a need to upgrade to Webpack v5, which will likely be a large effort.

rusackas added a commit that referenced this pull request Jul 1, 2021
@rusackas
Copy link
Member

rusackas commented Jul 1, 2021

Revert PR opened @graceguo-supercat - #15508

@graceguo-supercat
Copy link

thank you @kgabryje @nytai and @rusackas for investigation!

graceguo-supercat pushed a commit to airbnb/superset-fork that referenced this pull request Jul 7, 2021
rusackas added a commit that referenced this pull request Jul 8, 2021
rusackas added a commit that referenced this pull request Jul 8, 2021
* Revert "chore: bump @svgr/webpack to 5.5.0 (#15349)"

This reverts commit 53aa351.

* refreshing package-lock after rebasing
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* Revert "chore: bump @svgr/webpack to 5.5.0 (apache#15349)"

This reverts commit 53aa351.

* refreshing package-lock after rebasing
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* Revert "chore: bump @svgr/webpack to 5.5.0 (apache#15349)"

This reverts commit 53aa351.

* refreshing package-lock after rebasing
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* Revert "chore: bump @svgr/webpack to 5.5.0 (apache#15349)"

This reverts commit ccd0439.

* refreshing package-lock after rebasing
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants