Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update DASHBOARD_RBAC #15514

Merged
merged 1 commit into from
Jul 2, 2021
Merged

chore(docs): update DASHBOARD_RBAC #15514

merged 1 commit into from
Jul 2, 2021

Conversation

amitmiran137
Copy link
Member

SUMMARY

At Nielsen , we have been using that feature for about 2 months now.
we setup a specific role for every dashboard and associate users to the relevant dashboard to get read access to the dashboard and the data in the charts with zero issues so far

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@amitmiran137 amitmiran137 requested review from srinify, villebro and a team July 1, 2021 20:22
@amitmiran137 amitmiran137 changed the title chors(docs): update DASHBOARD_RBAC chore(docs): update DASHBOARD_RBAC Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #15514 (8b797fe) into master (7f2f51b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15514   +/-   ##
=======================================
  Coverage   77.24%   77.24%           
=======================================
  Files         975      975           
  Lines       50866    50866           
  Branches     6740     6740           
=======================================
  Hits        39293    39293           
  Misses      11357    11357           
  Partials      216      216           
Flag Coverage Δ
hive 81.38% <ø> (ø)
javascript 71.86% <ø> (ø)
mysql 81.64% <ø> (ø)
postgres 81.66% <ø> (ø)
presto 81.37% <ø> (ø)
python 82.19% <ø> (ø)
sqlite 81.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2f51b...8b797fe. Read the comment docs.

@srinify srinify merged commit e5ab9a4 into master Jul 2, 2021
Copy link

@fintzd fintzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me !

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@rusackas rusackas deleted the amitmiran137-patch-3 branch January 30, 2023 19:22
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants