Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base requirements missing deprecation pkg #15527

Merged
merged 1 commit into from Jul 4, 2021

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jul 2, 2021

SUMMARY

Add missing deprecation package to requirements base. Also nit sort on setup.py

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #15527 (08da1be) into master (81633e9) will decrease coverage by 0.13%.
The diff coverage is 58.82%.

❗ Current head 08da1be differs from pull request most recent head 9a3731f. Consider uploading reports for the commit 9a3731f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15527      +/-   ##
==========================================
- Coverage   76.97%   76.83%   -0.14%     
==========================================
  Files         976      976              
  Lines       51250    51260      +10     
  Branches     6897     6900       +3     
==========================================
- Hits        39450    39387      -63     
- Misses      11581    11654      +73     
  Partials      219      219              
Flag Coverage Δ
hive ?
mysql 81.62% <ø> (ø)
postgres 81.64% <ø> (ø)
presto 81.34% <ø> (+<0.01%) ⬆️
python 81.91% <ø> (-0.26%) ⬇️
sqlite 81.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dashboard/actions/hydrate.js 1.70% <0.00%> (-0.02%) ⬇️
superset-frontend/src/dataMask/actions.ts 38.88% <33.33%> (-3.97%) ⬇️
...d/src/dashboard/components/FiltersBadge/Styles.tsx 94.87% <50.00%> (-2.43%) ⬇️
...omponents/nativeFilters/FilterBar/Header/index.tsx 89.74% <50.00%> (-0.26%) ⬇️
...end/src/dashboard/components/SliceHeader/index.tsx 90.56% <75.00%> (-1.44%) ⬇️
.../components/FiltersBadge/FilterIndicator/index.tsx 100.00% <100.00%> (ø)
superset-frontend/src/dataMask/reducer.ts 65.30% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.20% <0.00%> (-17.21%) ⬇️
superset/connectors/sqla/models.py 89.63% <0.00%> (-0.24%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81633e9...9a3731f. Read the comment docs.

@dpgaspar dpgaspar requested a review from a team July 2, 2021 14:55
Copy link

@fintzd fintzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, is the bot (Codecov) only raising a warning due to the minimal decreased coverage, which in turn is due to the deprecation? (just wanted to check if I got this right) Thanks!

@dpgaspar
Copy link
Member Author

dpgaspar commented Jul 2, 2021

Looks good to me, is the bot only raising a warning due to the minimal decreased coverage, which in turn is due to the deprecation? (just wanted to check if I got this right) Thanks!

don't think it's because of the deprecation, see no reason for coverage decrease, maybe it has to finish all tests first

@fintzd
Copy link

fintzd commented Jul 2, 2021

Looks good to me, is the bot only raising a warning due to the minimal decreased coverage, which in turn is due to the deprecation? (just wanted to check if I got this right) Thanks!

don't think it's because of the deprecation, see no reason for coverage decrease, maybe it has to finish all tests first

Thank you @dpgaspar ! Sorry, I'm new to this repo and have not worked with this Codecov yet!

@amitmiran137 amitmiran137 merged commit dd16468 into apache:master Jul 4, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Feb 19, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants