New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: versions aren't pinned and pip-compile-validate doesn't detect dependency changes #15573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15573 +/- ##
=======================================
Coverage 76.95% 76.95%
=======================================
Files 976 976
Lines 51326 51326
Branches 6912 6912
=======================================
+ Hits 39498 39500 +2
+ Misses 11607 11605 -2
Partials 221 221
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8 tasks
ofekisr
force-pushed
the
fix/use_pip_compile_better
branch
from
July 8, 2021 09:51
396191d
to
abd999b
Compare
…ions are not pinned
ofekisr
changed the title
fix: pip-compile-validate does not detect dependency changes
fix: versions doesn't pinned and pip-compile-validate doesn't detect dependency changes
Jul 8, 2021
ofekisr
changed the title
fix: versions doesn't pinned and pip-compile-validate doesn't detect dependency changes
fix: versions don't pinned and pip-compile-validate doesn't detect dependency changes
Jul 8, 2021
ofekisr
changed the title
fix: versions don't pinned and pip-compile-validate doesn't detect dependency changes
fix: versions aren't pinned and pip-compile-validate doesn't detect dependency changes
Jul 8, 2021
ofekisr
force-pushed
the
fix/use_pip_compile_better
branch
from
July 11, 2021 07:30
3871531
to
9d96d8b
Compare
# Conflicts: # requirements/base.txt # requirements/integration.txt # requirements/testing.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
A better best practice is to put all project dependencies into the requirements file instead of setup.py
so adding a new dependency will Imply running pip-compile-multi.
When adding a new dependency into setup.py, pip-comiple-multi verify will not detect the change.
this PR try to prevent issues like #15527
Actually, I adapted the way pip-compile-multi did
and you can take another reference here: pip-compile-issue
another Important issue this PR fix is the packages that were in setup.py weren't pinned versions so the client who installs superset is not guaranteed the superset's dependencies will be the same when code was merged
note - before the commit, after moving the packages from setup.py I ran
pip-compile-multi --no-upgrade
to ensurethat all requirements files are ok
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Before opening the pr, I ran tox to ensure superset init is running to prove superset was installed ( successful running the ci inside tox)
you can try run tox by yourself
in addition, if the pr checks success, it mean nothing breaks
ADDITIONAL INFORMATION