Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to icons for searchinput icons #15533

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jul 2, 2021

SUMMARY

This pr migrates the old icon to icons for the search and cancel x component in the listview.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
Screen Shot 2021-07-02 at 10 48 29 AM

after
Q dkfjla

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #15533 (e3e60c2) into master (ee2ee48) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e3e60c2 differs from pull request most recent head 2ae03c5. Consider uploading reports for the commit 2ae03c5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15533      +/-   ##
==========================================
- Coverage   76.97%   76.96%   -0.01%     
==========================================
  Files         976      976              
  Lines       51260    51266       +6     
  Branches     6900     6901       +1     
==========================================
+ Hits        39456    39458       +2     
- Misses      11585    11589       +4     
  Partials      219      219              
Flag Coverage Δ
javascript 71.37% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../database/DatabaseModal/DatabaseConnectionForm.tsx 63.09% <ø> (ø)
...s/CRUD/data/database/DatabaseModal/ModalHeader.tsx 91.66% <ø> (ø)
...end/src/components/Form/LabeledErrorBoundInput.tsx 100.00% <100.00%> (ø)
...rset-frontend/src/components/InfoTooltip/index.tsx 100.00% <100.00%> (ø)
...-frontend/src/components/PopoverDropdown/index.tsx 100.00% <100.00%> (ø)
...rset-frontend/src/components/SearchInput/index.tsx 100.00% <100.00%> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx 47.86% <100.00%> (ø)
...c/views/CRUD/data/database/DatabaseModal/styles.ts 82.72% <100.00%> (-3.39%) ⬇️
superset/connectors/sqla/models.py 89.89% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2ee48...2ae03c5. Read the comment docs.

@apache apache deleted a comment from github-actions bot Jul 4, 2021
@geido
Copy link
Member

geido commented Jul 4, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2021

@geido Ephemeral environment spinning up at http://52.37.198.57:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie merged commit fb322b5 into apache:master Jul 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2021

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants