-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate to icons for searchinput icons #15533
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15533 +/- ##
==========================================
- Coverage 76.97% 76.96% -0.01%
==========================================
Files 976 976
Lines 51260 51266 +6
Branches 6900 6901 +1
==========================================
+ Hits 39456 39458 +2
- Misses 11585 11589 +4
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://52.37.198.57:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
* initial commit * fix test * fix lint
* initial commit * fix test * fix lint
* initial commit * fix test * fix lint
SUMMARY
This pr migrates the old icon to icons for the search and cancel x component in the listview.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
after
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION