Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: icon to icons for tabs #15551

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jul 6, 2021

SUMMARY

This pr migrates old icon to icons for tab cancelx icon.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
Untitled Query 2 0
after
04 Untitled Query 2

TESTING INSTRUCTIONS

Go to sql editor and check the tabbed cancel x icon

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #15551 (7edb07e) into master (0af5a3d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7edb07e differs from pull request most recent head 02543f2. Consider uploading reports for the commit 02543f2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15551   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files         976      976           
  Lines       51320    51322    +2     
  Branches     6912     6912           
=======================================
+ Hits        39485    39487    +2     
  Misses      11616    11616           
  Partials      219      219           
Flag Coverage Δ
javascript 71.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Tabs/Tabs.tsx 96.77% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af5a3d...02543f2. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented Jul 6, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2021

@rusackas Ephemeral environment spinning up at http://54.185.27.244:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. However, I would love if we could solve the issue with the base icon color at the Icons component level.

@@ -119,6 +119,9 @@ const StyledEditableTabs = styled(StyledTabs)`
`}
`;

const StyledCancelXIcon = styled(Icons.CancelX)`
color: ${({ theme }) => theme.colors.grayscale.base};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in another PR. Here we should define whether the standard is to use the iconColor prop or go with this approach. Additionally, we might want to use this color as the base for the Icons component in general, to avoid repetition.

@pkdotson pkdotson merged commit cd4f979 into apache:master Jul 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants