Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: versions aren't pinned and pip-compile-validate doesn't detect dependency changes #15573

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/superset-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ jobs:
run: |
pip-upgrade
pip install -r requirements/testing.txt
pip install --no-deps .
- name: Setup postgres
if: steps.check.outcome == 'failure'
uses: ./.github/actions/cached-dependencies
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/superset-python-misc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
apt-get-install
pip-upgrade
pip install -r requirements/testing.txt
pip install --no-deps .
- name: pylint
if: steps.check.outcome == 'failure'
# `-j 0` run Pylint in parallel
Expand Down Expand Up @@ -68,6 +69,7 @@ jobs:
apt-get-install
pip-upgrade
pip install -r requirements/integration.txt
pip install --no-deps .
- name: pre-commit
run: pre-commit run --all-files

Expand All @@ -94,5 +96,6 @@ jobs:
apt-get-install
pip-upgrade
pip install -r requirements/base.txt
pip install --no-deps .
- name: Test babel extraction
run: flask fab babel-extract --target superset/translations --output superset/translations/messages.pot --config superset/translations/babel.cfg -k _,__,t,tn,tct
2 changes: 2 additions & 0 deletions .github/workflows/superset-python-presto-hive.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ jobs:
apt-get-install
pip-upgrade
pip install -r requirements/testing.txt
pip install --no-deps .
setup-postgres
- name: Run celery
if: steps.check.outcome == 'failure'
Expand Down Expand Up @@ -145,6 +146,7 @@ jobs:
apt-get-install
pip-upgrade
pip install -r requirements/testing.txt
pip install --no-deps .
setup-postgres
- name: Run celery
if: steps.check.outcome == 'failure'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/superset-python-unittest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ jobs:
apt-get-install
pip-upgrade
pip install -r requirements/testing.txt
pip install --no-deps .
setup-mysql
- name: Run celery
if: steps.check.outcome == 'failure'
Expand Down Expand Up @@ -123,6 +124,7 @@ jobs:
apt-get-install
pip-upgrade
pip install -r requirements/testing.txt
pip install --no-deps .
setup-postgres
- name: Run celery
if: steps.check.outcome == 'failure'
Expand Down Expand Up @@ -179,6 +181,7 @@ jobs:
apt-get-install
pip-upgrade
pip install -r requirements/testing.txt
pip install --no-deps .
mkdir ${{ github.workspace }}/.temp
- name: Run celery
if: steps.check.outcome == 'failure'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/superset-translations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jobs:
apt-get-install
pip-upgrade
pip install -r requirements/base.txt
pip install --no-deps .
- name: Test babel extraction
run: |
flask fab babel-extract --target superset/translations \
Expand Down
2 changes: 2 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ COPY --from=superset-node /app/superset-frontend /app/superset-frontend
## Lastly, let's install superset itself
COPY superset /app/superset
COPY setup.py MANIFEST.in README.md /app/
COPY ./requirements/base.txt /app/requirements/

RUN cd /app \
&& chown -R superset:superset * \
&& pip install -e .
Expand Down
1 change: 1 addition & 0 deletions RELEASING/Dockerfile.make_docs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ RUN git clone --depth 1 --branch ${VERSION} https://github.com/apache/superset.g
WORKDIR /superset
# install doc dependencies
RUN pip install -r requirements/base.txt
RUN pip install --no-deps .
# build the docs
RUN python setup.py build_sphinx

Expand Down
104 changes: 103 additions & 1 deletion requirements/base.in
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,108 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-e file:.
backoff>=1.8.0
bleach>=3.0.2, <4.0.0
cachelib>=0.1.1,<0.2
celery>=4.3.0, <5.0.0, !=4.4.1
click<8
colorama
contextlib2
croniter>=0.3.28
cron-descriptor
cryptography>=3.3.2
deprecation>=2.1.0, <2.2.0
flask>=1.1.0, <2.0.0
flask-appbuilder>=3.3.0, <4.0.0
flask-caching>=1.10.0
flask-compress
flask-talisman
flask-migrate
flask-wtf
geopy
graphlib-backport
gunicorn>=20.0.2, <20.1
holidays==0.10.3 # PINNED! https://github.com/dr-prodigy/python-holidays/issues/406
humanize
itsdangerous>=1.0.0, <2.0.0
isodate
markdown>=3.0
msgpack>=1.0.0, <1.1
pandas>=1.2.2, <1.3
parsedatetime
pathlib2
pgsanity
polyline
pyparsing>=2.4.7, <3.0.0
python-dateutil
python-dotenv
python-geohash
pyarrow>=4.0.1, <4.1
pyyaml>=5.4
PyJWT>=1.7.1, <2
redis
retry>=0.9.2
selenium>=3.141.0
simplejson>=3.15.0
slackclient==2.5.0 # PINNED! slack changes file upload api in the future versions
sqlalchemy>=1.3.16, <1.4, !=1.3.21
sqlalchemy-utils>=0.36.6,<0.37
sqlparse==0.3.0 # PINNED! see https://github.com/andialbrecht/sqlparse/issues/562
typing-extensions>=3.7.4.3,<4 # needed to support typing.Literal on py37
wtforms-json
pyparsing>=2.4.7, <3.0.0
holidays==0.10.3 # PINNED! https://github.com/dr-prodigy/python-holidays/issues/406
deprecation>=2.1.0, <2.2.0backoff>=1.8.0
bleach>=3.0.2, <4.0.0
cachelib>=0.1.1,<0.2
celery>=4.3.0, <5.0.0, !=4.4.1
click<8
colorama
contextlib2
croniter>=0.3.28
cron-descriptor
cryptography>=3.3.2
deprecation>=2.1.0, <2.2.0
flask>=1.1.0, <2.0.0
flask-appbuilder>=3.3.0, <4.0.0
flask-caching>=1.10.0
flask-compress
flask-talisman
flask-migrate
flask-wtf
geopy
graphlib-backport
gunicorn>=20.0.2, <20.1
holidays==0.10.3 # PINNED! https://github.com/dr-prodigy/python-holidays/issues/406
humanize
itsdangerous>=1.0.0, <2.0.0
isodate
markdown>=3.0
msgpack>=1.0.0, <1.1
pandas>=1.2.2, <1.3
parsedatetime
pathlib2
pgsanity
polyline
pyparsing>=2.4.7, <3.0.0
python-dateutil
python-dotenv
python-geohash
pyarrow>=4.0.1, <4.1
pyyaml>=5.4
PyJWT>=1.7.1, <2
redis
retry>=0.9.2
selenium>=3.141.0
simplejson>=3.15.0
slackclient==2.5.0 # PINNED! slack changes file upload api in the future versions
sqlalchemy>=1.3.16, <1.4, !=1.3.21
sqlalchemy-utils>=0.36.6,<0.37
sqlparse==0.3.0 # PINNED! see https://github.com/andialbrecht/sqlparse/issues/562
typing-extensions>=3.7.4.3,<4 # needed to support typing.Literal on py37
wtforms-json
pyparsing>=2.4.7, <3.0.0
holidays==0.10.3 # PINNED! https://github.com/dr-prodigy/python-holidays/issues/406
deprecation>=2.1.0, <2.2.0
pyrsistent>=0.16.1,<0.17
zipp==3.4.1