Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add section about updating Python requirements #15574

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

john-bodley
Copy link
Member

SUMMARY

Adding section in CONTRIBUTING.md regarding updating the Python requirements.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #15574 (b4a85b7) into master (83be06d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15574      +/-   ##
==========================================
- Coverage   76.95%   76.94%   -0.01%     
==========================================
  Files         976      976              
  Lines       51290    51290              
  Branches     6907     6907              
==========================================
- Hits        39468    39466       -2     
- Misses      11603    11605       +2     
  Partials      219      219              
Flag Coverage Δ
hive 81.28% <ø> (ø)
javascript 71.41% <ø> (ø)
mysql 81.54% <ø> (ø)
postgres 81.56% <ø> (ø)
presto 81.26% <ø> (-0.01%) ⬇️
python 82.09% <ø> (-0.01%) ⬇️
sqlite 81.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 89.89% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83be06d...b4a85b7. Read the comment docs.

@nytai
Copy link
Member

nytai commented Jul 7, 2021

@john-bodley is this compatible with changes in #15573

@john-bodley john-bodley force-pushed the john-bodley--contributing-python-requirements branch from db22658 to b4a85b7 Compare July 13, 2021 17:25
@john-bodley john-bodley merged commit ad87ba3 into master Jul 13, 2021
@john-bodley john-bodley deleted the john-bodley--contributing-python-requirements branch July 13, 2021 19:26
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants