feat: Make Google Sheets Dyanmic #15576

AAfghahi · 2021-07-07T20:18:42Z

SUMMARY

Will Come when finished.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2021-07-07T22:02:22Z

Codecov Report

Merging #15576 (d6b95a6) into pexdax/improved-sheets (301b94f) will decrease coverage by 0.26%.
The diff coverage is 82.75%.

❗ Current head d6b95a6 differs from pull request most recent head 3882bcd. Consider uploading reports for the commit 3882bcd to get more accurate results

@@                    Coverage Diff                     @@
##           pexdax/improved-sheets   #15576      +/-   ##
==========================================================
- Coverage                   76.96%   76.69%   -0.27%     
==========================================================
  Files                         976      976              
  Lines                       51318    51307      -11     
  Branches                     6907     6907              
==========================================================
- Hits                        39496    39350     -146     
- Misses                      11603    11738     +135     
  Partials                      219      219

Flag	Coverage Δ
hive	`?`
mysql	`81.56% <82.75%> (+<0.01%)`	⬆️
postgres	`?`
presto	`?`
python	`81.59% <82.75%> (-0.52%)`	⬇️
sqlite	`81.19% <82.75%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engine_specs/gsheets.py	`77.52% <82.75%> (+2.52%)`	⬆️
superset/db_engines/hive.py	`0.00% <0.00%> (-82.15%)`	⬇️
superset/sql_validators/postgres.py	`50.00% <0.00%> (-50.00%)`	⬇️
superset/db_engine_specs/hive.py	`69.44% <0.00%> (-17.07%)`	⬇️
superset/db_engine_specs/presto.py	`83.36% <0.00%> (-6.95%)`	⬇️
superset/db_engine_specs/postgres.py	`94.05% <0.00%> (-2.98%)`	⬇️
superset/models/dashboard.py	`73.42% <0.00%> (-2.45%)`	⬇️
superset/views/database/mixins.py	`81.03% <0.00%> (-1.73%)`	⬇️
superset/connectors/sqla/models.py	`88.24% <0.00%> (-1.66%)`	⬇️
superset/views/base_api.py	`97.85% <0.00%> (-0.43%)`	⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 301b94f...3882bcd. Read the comment docs.

hughhhh · 2021-07-07T23:04:13Z

Can you add a Gsheets to the api_test.py for the available endpoint

hughhhh · 2021-07-08T17:34:02Z

superset/db_engine_specs/gsheets.py

+    def build_sqlalchemy_uri(cls) -> str:
+        # All gsheets return just the engine in the format of the uri,
+        # the above are temporary for csi
+        if not cls:


remove this we dont need to check the cls method it come built int

I added this because you can't have a method without a variable in it.

Or could I do def build_sqlalchemy_uri: ?

hughhhh · 2021-07-08T17:34:09Z

superset/db_engine_specs/gsheets.py

+            Dict[str, str]
+        ] = None,  # pylint: disable=unused-argument
+    ) -> Any:
+        # value = make_url(uri)


remove this comment

* feat: Make Google Sheets Dyanmic (#15576) * first draft * second draft * added tests * first draft * added table_catalog * remove console.log * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * revisions * save this for now * working form * save disable on public sheets * refactor somethings * saving this for now * working edit * add back query to schema * working add * fix styling * fixing x * fix linting * prettier * fix some type issues * more lint fixes * remove unused dependency * fix linint * fix validation * pylint bypass * pylint bypass * fix this * fix mypy * yerp * fix test * fix test * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * wrap add sheets * fix linting issues * fix unit test * ignore typing * fix editting and paste issues * remove query * fix this * fix test * add test back * fix error messaging * update url messaging on error * change error type * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * add errors for sheets with no name * fix * fix messaging for gsheets * stop pylint * update line Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Arash <arash.afghahi@gmail.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* feat: Make Google Sheets Dyanmic (apache#15576) * first draft * second draft * added tests * first draft * added table_catalog * remove console.log * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * revisions * save this for now * working form * save disable on public sheets * refactor somethings * saving this for now * working edit * add back query to schema * working add * fix styling * fixing x * fix linting * prettier * fix some type issues * more lint fixes * remove unused dependency * fix linint * fix validation * pylint bypass * pylint bypass * fix this * fix mypy * yerp * fix test * fix test * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * wrap add sheets * fix linting issues * fix unit test * ignore typing * fix editting and paste issues * remove query * fix this * fix test * add test back * fix error messaging * update url messaging on error * change error type * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * add errors for sheets with no name * fix * fix messaging for gsheets * stop pylint * update line Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Arash <arash.afghahi@gmail.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

first draft

c15257b

pull-request-size bot added the size/M label Jul 7, 2021

AAfghahi changed the base branch from master to pexdax/improved-sheets July 7, 2021 21:44

AAfghahi marked this pull request as ready for review July 7, 2021 21:47

second draft

b0766c2

AAfghahi force-pushed the ch19360_googleDynamicForm branch from d5ae865 to b0766c2 Compare July 7, 2021 22:04

pull-request-size bot added size/L and removed size/M labels Jul 8, 2021

added tests

3914df2

AAfghahi force-pushed the ch19360_googleDynamicForm branch from e3339a7 to 3914df2 Compare July 8, 2021 15:48

pull-request-size bot added size/M and removed size/L labels Jul 8, 2021

AAfghahi force-pushed the ch19360_googleDynamicForm branch from 82cad35 to 2227933 Compare July 8, 2021 16:58

hughhhh reviewed Jul 8, 2021

View reviewed changes

AAfghahi force-pushed the ch19360_googleDynamicForm branch 2 times, most recently from 07fcc77 to 4516090 Compare July 8, 2021 18:01

Merge branch 'pexdax/improved-sheets' into ch19360_googleDynamicForm

3882bcd

AAfghahi force-pushed the ch19360_googleDynamicForm branch from 4516090 to 3882bcd Compare July 8, 2021 18:08

hughhhh merged commit accb48e into apache:pexdax/improved-sheets Jul 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Make Google Sheets Dyanmic #15576

feat: Make Google Sheets Dyanmic #15576

AAfghahi commented Jul 7, 2021

codecov bot commented Jul 7, 2021 •

edited

hughhhh commented Jul 7, 2021

hughhhh Jul 8, 2021

AAfghahi Jul 8, 2021

hughhhh Jul 8, 2021

feat: Make Google Sheets Dyanmic #15576

feat: Make Google Sheets Dyanmic #15576

Conversation

AAfghahi commented Jul 7, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Jul 7, 2021 • edited

Codecov Report

hughhhh commented Jul 7, 2021

hughhhh Jul 8, 2021

Choose a reason for hiding this comment

AAfghahi Jul 8, 2021

Choose a reason for hiding this comment

hughhhh Jul 8, 2021

Choose a reason for hiding this comment

codecov bot commented Jul 7, 2021 •

edited