feat(dbc ui): Adding Google Sheets Dynamic Form #15801

hughhhh · 2021-07-20T16:25:45Z

SUMMARY

Added new Google Sheets form using the new DBC UI. Users are now able to add a set of google sheets as a database to superset. This flow makes it super easier for people trying build quick chart for reporting, or provide a flexible db for updating.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

google-sheets.mov

TESTING INSTRUCTIONS

Goto Database
Select Google Sheets
Input name and url of public sheet
Click Connect

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

* first draft * second draft * added tests

…atabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

…ndex.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

…perset into pexdax/improved-sheets

…perset into ch18764_gsheetsAdd

…/gsheets-public

betodealmeida · 2021-07-26T19:31:19Z

tests/unit_tests/db_engine_specs/test_gsheets.py

-    create_engine.assert_called_with(
-        "gsheets://", service_account_info={}, subject="admin@example.com",
-    )


Why are we getting rid of this test?

no clue how these got removed guess it was a bad merge conflict on my end

betodealmeida · 2021-07-26T19:31:45Z

tests/unit_tests/db_engine_specs/test_gsheets.py

-    create_engine.assert_called_with(
-        "gsheets://", service_account_info={}, subject="admin@example.com",
-    )


…/gsheets-public

betodealmeida

This looks good, but I'm getting a bit worried about the complexity of database modal as we support more and more databases.

superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

…ndex.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* feat: Make Google Sheets Dyanmic (apache#15576) * first draft * second draft * added tests * first draft * added table_catalog * remove console.log * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * revisions * save this for now * working form * save disable on public sheets * refactor somethings * saving this for now * working edit * add back query to schema * working add * fix styling * fixing x * fix linting * prettier * fix some type issues * more lint fixes * remove unused dependency * fix linint * fix validation * pylint bypass * pylint bypass * fix this * fix mypy * yerp * fix test * fix test * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * wrap add sheets * fix linting issues * fix unit test * ignore typing * fix editting and paste issues * remove query * fix this * fix test * add test back * fix error messaging * update url messaging on error * change error type * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * add errors for sheets with no name * fix * fix messaging for gsheets * stop pylint * update line Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Arash <arash.afghahi@gmail.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

AAfghahi and others added 17 commits July 8, 2021 12:58

feat: Make Google Sheets Dyanmic (#15576)

accb48e

* first draft * second draft * added tests

first draft

eb5f607

added table_catalog

459eba3

remove console.log

9aba8fc

Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/D…

6b30f79

…atabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/i…

962e597

…ndex.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

revisions

0e4f249

revisions

84222b2

save this for now

4b466ad

working form

aa65132

Merge branch 'pexdax/improved-sheets' of https://github.com/apache/su…

5594a3b

…perset into pexdax/improved-sheets

Merge branch 'pexdax/improved-sheets' of https://github.com/apache/su…

bd089fb

…perset into ch18764_gsheetsAdd

save disable on public sheets

fca0ca8

refactor somethings

640ecab

saving this for now

e951350

working edit

4714264

add back query to schema

ce0c894

AAfghahi mentioned this pull request Jul 20, 2021

feat: Gsheet adding sheets component #15598

Closed

8 tasks

hughhhh added 12 commits July 20, 2021 14:44

working add

afcab7c

fix styling

a30b0d8

fixing x

bdcaf2b

fix linting

1b73a07

prettier

cd8f7c6

fix some type issues

1e020f9

more lint fixes

ee9a363

Merge branch 'master' of https://github.com/apache/superset into hugh…

e7e8819

…/gsheets-public

remove unused dependency

cbd43b3

fix linint

54186da

fix validation

630dcb1

pylint bypass

58a36f0

hughhhh added 2 commits July 22, 2021 12:11

fix editting and paste issues

a3b65fd

remove query

0121617

pull-request-size bot added the size/XL label Jul 24, 2021

hughhhh added 2 commits July 24, 2021 20:31

fix this

c24e074

fix test

29deada

hughhhh force-pushed the hugh/gsheets-public branch from 4e80983 to 29deada Compare July 25, 2021 16:27

hughhhh requested review from betodealmeida and eschutho July 25, 2021 22:15

betodealmeida reviewed Jul 26, 2021

View reviewed changes

hughhhh added 2 commits July 26, 2021 13:04

add test back

92f473b

Merge branch 'master' of https://github.com/apache/superset into hugh…

4363d60

…/gsheets-public

betodealmeida approved these changes Jul 26, 2021

View reviewed changes

superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Outdated Show resolved Hide resolved

hughhhh and others added 9 commits July 27, 2021 08:40

fix error messaging

30fc76e

update url messaging on error

7c59782

change error type

53c365b

Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/i…

90d7268

…ndex.tsx Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

add errors for sheets with no name

eed363b

fix

84621fa

fix messaging for gsheets

e988d38

stop pylint

c71de88

update line

451c533

hughhhh merged commit bfe7eb9 into master Jul 28, 2021

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024

mistercrunch deleted the hugh/gsheets-public branch March 26, 2024 17:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dbc ui): Adding Google Sheets Dynamic Form #15801

feat(dbc ui): Adding Google Sheets Dynamic Form #15801

hughhhh commented Jul 20, 2021 •

edited

betodealmeida Jul 26, 2021

hughhhh Jul 26, 2021

betodealmeida Jul 26, 2021

betodealmeida left a comment

feat(dbc ui): Adding Google Sheets Dynamic Form #15801

feat(dbc ui): Adding Google Sheets Dynamic Form #15801

Conversation

hughhhh commented Jul 20, 2021 • edited

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

betodealmeida Jul 26, 2021

Choose a reason for hiding this comment

hughhhh Jul 26, 2021

Choose a reason for hiding this comment

betodealmeida Jul 26, 2021

Choose a reason for hiding this comment

betodealmeida left a comment

Choose a reason for hiding this comment

hughhhh commented Jul 20, 2021 •

edited