Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update db for expose in sqllab param #15609

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 9, 2021

SUMMARY

Properly passing the default value of sqlllab params from the api

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #15609 (2450142) into master (2be52c0) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head 2450142 differs from pull request most recent head 301ce86. Consider uploading reports for the commit 301ce86 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15609      +/-   ##
==========================================
- Coverage   76.88%   76.73%   -0.15%     
==========================================
  Files         976      976              
  Lines       51320    51321       +1     
  Branches     6907     6907              
==========================================
- Hits        39458    39382      -76     
- Misses      11643    11720      +77     
  Partials      219      219              
Flag Coverage Δ
hive ?
mysql 81.56% <100.00%> (+<0.01%) ⬆️
postgres 81.58% <100.00%> (+<0.01%) ⬆️
python 81.67% <100.00%> (-0.29%) ⬇️
sqlite 81.19% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/api.py 92.95% <100.00%> (+0.02%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.44% <0.00%> (-17.07%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-1.06%) ⬇️
superset/db_engine_specs/base.py 88.14% <0.00%> (-0.40%) ⬇️
superset/connectors/sqla/models.py 88.26% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 88.97% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be52c0...301ce86. Read the comment docs.

@betodealmeida betodealmeida merged commit f67e402 into master Jul 9, 2021
@rosemarie-chiu
Copy link
Contributor

🏷 2021.27

henryyeh pushed a commit to preset-io/superset that referenced this pull request Jul 13, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
@mistercrunch mistercrunch deleted the hugh/fix-expose_in_sqllab branch March 26, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.27 size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants