Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: icon to icons for annotations & css templates modals #15611

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jul 9, 2021

SUMMARY

migrates annotations modal icons to the new icons component

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-07-08 at 7 48 50 PM

Screen Shot 2021-07-08 at 8 23 25 PM

TESTING INSTRUCTIONS

Go to annotations page and look at the modal title icons

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #15611 (5902be1) into master (4ab565c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15611   +/-   ##
=======================================
  Coverage   76.88%   76.88%           
=======================================
  Files         976      976           
  Lines       51317    51318    +1     
  Branches     6907     6907           
=======================================
+ Hits        39455    39456    +1     
  Misses      11643    11643           
  Partials      219      219           
Flag Coverage Δ
javascript 71.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/views/CRUD/annotation/AnnotationModal.tsx 62.68% <100.00%> (-0.28%) ⬇️
...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx 69.47% <100.00%> (-0.32%) ⬇️
...d/src/views/CRUD/csstemplates/CssTemplateModal.tsx 67.30% <100.00%> (-0.32%) ⬇️
superset-frontend/src/views/CRUD/utils.tsx 64.16% <100.00%> (+0.30%) ⬆️
...re/components/controls/CollectionControl/index.jsx 83.33% <0.00%> (ø)
...nts/controls/DateFilterControl/DateFilterLabel.tsx 66.93% <0.00%> (+0.26%) ⬆️
...re/components/controls/DatasourceControl/index.jsx 87.17% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab565c...5902be1. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 9, 2021
@pkdotson pkdotson changed the title refactor: icon to icons for annotations modals refactor: icon to icons for annotations & css templates modals Jul 9, 2021
@pkdotson pkdotson merged commit cc765b5 into apache:master Jul 9, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants