Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reverts reset form in native filters #15644

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jul 12, 2021

SUMMARY

Revert the removal of resetForm made in #15572. Changes made in that PR caused the cancel functionality to stop working.

@simcha90 @kgabryje @rusackas

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

screen-recording-2021-07-12-at-62719-pm_GWlTiSvl.mp4
screen-recording-2021-07-12-at-62627-pm_RtxL6h0r.mp4

TESTING INSTRUCTIONS

See before/after videos.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #15644 (79d9060) into master (34542db) will decrease coverage by 0.07%.
The diff coverage is 64.70%.

❗ Current head 79d9060 differs from pull request most recent head ea3268d. Consider uploading reports for the commit ea3268d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15644      +/-   ##
==========================================
- Coverage   76.99%   76.91%   -0.08%     
==========================================
  Files         978      978              
  Lines       51486    51493       +7     
  Branches     6950     6951       +1     
==========================================
- Hits        39642    39608      -34     
- Misses      11620    11661      +41     
  Partials      224      224              
Flag Coverage Δ
javascript 71.52% <62.50%> (+<0.01%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 47.57% <14.28%> (+0.15%) ⬆️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 95.23% <100.00%> (+0.36%) ⬆️
...nd/src/dashboard/util/activeAllDashboardFilters.ts 92.59% <100.00%> (ø)
.../CRUD/data/database/DatabaseModal/ExtraOptions.tsx 92.85% <100.00%> (ø)
superset/db_engine_specs/postgres.py 97.02% <100.00%> (ø)
superset/db_engine_specs/presto.py 84.42% <0.00%> (-5.90%) ⬇️
superset/connectors/sqla/models.py 88.49% <0.00%> (-1.41%) ⬇️
superset/models/core.py 89.79% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34542db...ea3268d. Read the comment docs.

// After this, it should be as if the modal was just opened fresh.
// Called when the modal is closed.
const resetForm = () => {
form.resetFields();
Copy link
Contributor

@simcha90 simcha90 Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this line (form.resetFields();) because it cause issue that described in previous PR...
Also form will be destroyed automatically, after modal closed

But other lines of this function is good to have - to reset local state :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line removed! Thanks!

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit f0c0d74 into apache:master Jul 13, 2021
Native dashboard filters automation moved this from In progress to Done Jul 13, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v1.3 🚢 1.3.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants