-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Reverts reset form in native filters #15644
chore: Reverts reset form in native filters #15644
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15644 +/- ##
==========================================
- Coverage 76.99% 76.91% -0.08%
==========================================
Files 978 978
Lines 51486 51493 +7
Branches 6950 6951 +1
==========================================
- Hits 39642 39608 -34
- Misses 11620 11661 +41
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
// After this, it should be as if the modal was just opened fresh. | ||
// Called when the modal is closed. | ||
const resetForm = () => { | ||
form.resetFields(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need this line (form.resetFields();
) because it cause issue that described in previous PR...
Also form will be destroyed automatically, after modal closed
But other lines of this function is good to have - to reset local state :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line removed! Thanks!
d210767
to
ea3268d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
Revert the removal of
resetForm
made in #15572. Changes made in that PR caused the cancel functionality to stop working.@simcha90 @kgabryje @rusackas
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
screen-recording-2021-07-12-at-62719-pm_GWlTiSvl.mp4
screen-recording-2021-07-12-at-62627-pm_RtxL6h0r.mp4
TESTING INSTRUCTIONS
See before/after videos.
ADDITIONAL INFORMATION