Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: margin right on warning icon to 8px #15715

Merged
merged 2 commits into from Jul 19, 2021
Merged

fix: margin right on warning icon to 8px #15715

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efe756c
changed margin right on warning icon to 8px
stellalc7 Jul 15, 2021
a75d31b
fixed to grid units from pixels
stellalc7 Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion superset-frontend/src/components/WarningIconWithTooltip/index.tsx
View file
Open in desktop
Expand Up @@ -35,7 +35,10 @@ function WarningIconWithTooltip({
id="warning-tooltip"
title={<SafeMarkdown source={warningMarkdown} />}
>
<Icons.AlertSolid iconColor={theme.colors.alert.base} />
<Icons.AlertSolid
iconColor={theme.colors.alert.base}
css={{ marginRight: `8px` }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use grid units.

Suggested change
css={{ marginRight: `8px` }}
css={{ marginRight: `${theme.gridUnit * 2}px` }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I just saw your exact suggestion - let me know if what I coded is not exactly correct. Thanks!

/>
</Tooltip>
);
}
Expand Down