fix: margin right on warning icon to 8px #15715

stellalc7 · 2021-07-15T18:46:27Z

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2021-07-15T19:06:25Z

Codecov Report

Merging #15715 (a75d31b) into master (c7c6375) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #15715      +/-   ##
==========================================
- Coverage   77.25%   76.94%   -0.32%     
==========================================
  Files         971      979       +8     
  Lines       50308    51165     +857     
  Branches     6140     6980     +840     
==========================================
+ Hits        38867    39370     +503     
- Misses      11237    11573     +336     
- Partials      204      222      +18

Flag	Coverage Δ
javascript	`71.35% <100.00%> (-0.46%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nd/src/components/WarningIconWithTooltip/index.tsx	`100.00% <100.00%> (ø)`
superset-frontend/src/dataMask/actions.ts	`38.88% <0.00%> (-39.69%)`	⬇️
...ts/nativeFilters/FilterBar/FilterControls/utils.ts	`71.42% <0.00%> (-28.58%)`	⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx	`47.57% <0.00%> (-27.75%)`	⬇️
superset-frontend/src/chart/ChartRenderer.jsx	`37.97% <0.00%> (-16.58%)`	⬇️
...c/views/CRUD/data/database/DatabaseModal/styles.ts	`83.63% <0.00%> (-13.63%)`	⬇️
...nd/src/dashboard/components/FiltersBadge/index.tsx	`86.74% <0.00%> (-13.26%)`	⬇️
superset-frontend/src/filters/components/common.ts	`90.00% <0.00%> (-10.00%)`	⬇️
...et-frontend/src/filters/components/Select/index.ts	`90.00% <0.00%> (-10.00%)`	⬇️
...d/src/explore/components/DatasourcePanel/index.tsx	`81.33% <0.00%> (-9.74%)`	⬇️
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c6375...a75d31b. Read the comment docs.

suddjian · 2021-07-15T20:34:17Z

superset-frontend/src/components/WarningIconWithTooltip/index.tsx

-      <Icons.AlertSolid iconColor={theme.colors.alert.base} />
+      <Icons.AlertSolid
+        iconColor={theme.colors.alert.base}
+        css={{ marginRight: `8px` }}


Let's use grid units.

Suggested change

css={{ marginRight: `8px` }}

css={{ marginRight: `${theme.gridUnit * 2}px` }}

Oh, I just saw your exact suggestion - let me know if what I coded is not exactly correct. Thanks!

suddjian

Thanks for the fix! Happy to merge once pixel values are in grid units.

geido

LGTM! Thanks for the contribution

stellalc7 · 2021-07-19T19:31:47Z

hey @suddjian! did you need me to do anything else on this PR? :)

suddjian

Looks good, thank you!

* changed margin right on warning icon to 8px * fixed to grid units from pixels

#15856) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> * feat: toggle the ReportModal Icon based on user permissions (#15780) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * added testing props * cleaned up rebase * changed name and type Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * feat: Begin incorporation of email report modal to Charts (#15793) * Add email report modal to Charts * Fix px themes * feat: fetch UI specific reports (#15785) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * created Api call * added click logic * made the fetch report into a action/reducer * abstracted report action * revision * added reportState to reducer * reports conditions * revisions * revisions Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * fix: Edit physical dataset from the Edit Dataset modal (#15770) * Remove unnecessary onChange * Remove confliciting onChange * Revert unnecessary change * Enhance and fix tests * feat: add show columns to Reports model (#15712) * added logic for creation_method * revisions * added index * Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py * filters * search columns updated * fix: margin right on warning icon to 8px (#15715) * changed margin right on warning icon to 8px * fixed to grid units from pixels * feat: adding Progress Bar to Benchmark script (#15719) * rough draft of benchmark script * revisions * revisions * rough draft of benchmark script * revisions * Update requirements/development.in Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset/utils/mock_data.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * more revisions Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * fix: migration downgrade references wrong column (#15791) * fix(dashboard): Add resize handles to right and bottom of component (#15778) * fix(dashboard): Add resize handles to right and bottom of component * Fix test * chore: Add tags to the new viz gallery (#15734) * chore: add tags to gallery * fix UT * fix lint * redesign tags filter * chore: change to Highly-used and fix some css * fix UT Co-authored-by: stephenLYZ <750188453@qq.com> * chore: bump 0.17.70 (#15795) * docs: Adding Sunbird to users list (#15794) * chore: Improves the Select component UI/UX - iteration 4 (#15480) * Add z-index only on maximize (#15800) * chore: remove `retry` dependency in favor of `backoff` (#15788) * chore: remove retry dep in favor of backoff * Fix lint * fix: create fk model in benchmark script (#15804) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * Working on onSave functionality * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> * feat: toggle the ReportModal Icon based on user permissions (#15780) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * added testing props * cleaned up rebase * changed name and type Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * feat: fetch UI specific reports (#15785) * style: Rough draft of email report modal (#15666) * clears errors when closing out of modal (#15623) * fix: avoid fetching favorite status for anonymous user (#15590) * avoid fetching favorite status for anonymous user * add test + fix types * fix lint errors * Building ReportModal component * Continued ReportModal creation * Visual details updated * CronError style * Very basic testing added Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * first draft * created Api call * added click logic * made the fetch report into a action/reducer * abstracted report action * revision * added reportState to reducer * reports conditions * revisions * revisions Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> * Dashboard onSave progress * More onSave/create progress * Dashboard POST working! * Dashboard POST relocated to redux * POST now also working in Charts * making linter happy * linter again Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: aspedrosa <aspedrosa@ua.pt> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: stellalc7 <stellalc7@gmail.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: stephenLYZ <750188453@qq.com> Co-authored-by: Kumar <kumarks1122@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* changed margin right on warning icon to 8px * fixed to grid units from pixels

changed margin right on warning icon to 8px

efe756c

stellalc7 changed the title ~~changed margin right on warning icon to 8px~~ fix: margin right on warning icon to 8px Jul 15, 2021

AAfghahi approved these changes Jul 15, 2021

View reviewed changes

suddjian reviewed Jul 15, 2021

View reviewed changes

suddjian requested changes Jul 15, 2021

View reviewed changes

fixed to grid units from pixels

a75d31b

junlincc added the hold! On hold label Jul 16, 2021

geido approved these changes Jul 16, 2021

View reviewed changes

suddjian approved these changes Jul 19, 2021

View reviewed changes

suddjian merged commit 9a14aed into apache:master Jul 19, 2021

lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Jul 26, 2021

fix: margin right on warning icon to 8px (apache#15715)

74e120d

* changed margin right on warning icon to 8px * fixed to grid units from pixels

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021

fix: margin right on warning icon to 8px (apache#15715)

3b929da

* changed margin right on warning icon to 8px * fixed to grid units from pixels

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021

fix: margin right on warning icon to 8px (apache#15715)

253ba32

* changed margin right on warning icon to 8px * fixed to grid units from pixels

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

fix: margin right on warning icon to 8px (apache#15715)

f271e85

* changed margin right on warning icon to 8px * fixed to grid units from pixels

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: margin right on warning icon to 8px #15715

fix: margin right on warning icon to 8px #15715

stellalc7 commented Jul 15, 2021

codecov bot commented Jul 15, 2021 •

edited

suddjian Jul 15, 2021

stellalc7 Jul 15, 2021

suddjian left a comment

geido left a comment

stellalc7 commented Jul 19, 2021

suddjian left a comment

	css={{ marginRight: `8px` }}
	css={{ marginRight: `${theme.gridUnit * 2}px` }}

fix: margin right on warning icon to 8px #15715

fix: margin right on warning icon to 8px #15715

Conversation

stellalc7 commented Jul 15, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Jul 15, 2021 • edited

Codecov Report

suddjian Jul 15, 2021

Choose a reason for hiding this comment

stellalc7 Jul 15, 2021

Choose a reason for hiding this comment

suddjian left a comment

Choose a reason for hiding this comment

geido left a comment

Choose a reason for hiding this comment

stellalc7 commented Jul 19, 2021

suddjian left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 15, 2021 •

edited