Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): wrong error message in conditional formatting #15732

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

kgabryje
Copy link
Member

SUMMARY

Fix an incorrect error message for right target value when it's bigger than left target value.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

This will be testable once we bump table and pivot table v2 plugins versions in Superset.

  1. Create a Table or Pivot table v2 chart
  2. Open conditional formatting popover
  3. Select a "between" operator and set right target value to be smaller than left.
  4. Verify that the error message is correct

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #15732 (5a3d9c1) into master (b489cff) will increase coverage by 0.08%.
The diff coverage is 47.42%.

❗ Current head 5a3d9c1 differs from pull request most recent head cc4fce2. Consider uploading reports for the commit cc4fce2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15732      +/-   ##
==========================================
+ Coverage   76.82%   76.91%   +0.08%     
==========================================
  Files         983      983              
  Lines       51585    51602      +17     
  Branches     6974     6980       +6     
==========================================
+ Hits        39632    39688      +56     
+ Misses      11729    11691      -38     
+ Partials      224      223       -1     
Flag Coverage Δ
javascript 71.34% <39.74%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/SqlLab/components/HighlightedSql.tsx 90.32% <ø> (ø)
superset-frontend/src/chart/Chart.jsx 46.29% <ø> (ø)
...ontend/src/common/hooks/apiResources/dashboards.ts 40.00% <0.00%> (ø)
...set-frontend/src/dashboard/containers/Dashboard.ts 0.00% <0.00%> (ø)
...rontend/src/dashboard/containers/DashboardPage.tsx 0.00% <0.00%> (ø)
...onalFormattingControl/FormattingPopoverContent.tsx 33.33% <ø> (ø)
superset/utils/mock_data.py 24.81% <0.00%> (-0.37%) ⬇️
...rset-frontend/src/dashboard/actions/datasources.ts 25.00% <30.00%> (ø)
superset-frontend/src/chart/ChartRenderer.jsx 37.97% <50.00%> (+0.31%) ⬆️
...perset-frontend/src/explore/components/Control.tsx 76.47% <71.42%> (+1.47%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b489cff...cc4fce2. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kgabryje kgabryje merged commit 71924eb into apache:master Jul 16, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels v1.3 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants