chore: Enforce Mypy for non-tests #15757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--mypy-spit-and-polish
branch
from
d38ecf8
to
dc36cb4
Compare
Codecov Report
@@ Coverage Diff @@
## master #15757 +/- ##
==========================================
- Coverage 76.89% 76.70% -0.19%
==========================================
Files 984 984
Lines 51662 51627 -35
Branches 6991 6988 -3
==========================================
- Hits 39724 39599 -125
- Misses 11714 11805 +91
+ Partials 224 223 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
john-bodley
force-pushed
the
john-bodley--mypy-spit-and-polish
branch
2 times, most recently
from
541ddee
to
5f39b6f
Compare
etr2460
approved these changes
Jul 21, 2021
| @@ -61,7 +63,7 @@ def send_email( | |||
| server.sendmail(sender_email, receiver_email, message) | |||
|
|
|||
|
|
|||
| def render_template(template_file: str, **kwargs) -> str: | |||
| def render_template(template_file: str, **kwargs: Any) -> str: | |||
There was a problem hiding this comment.
@etr2460 it's more nuanced than that. kwargs are mostly represented as Any elsewhere in the code base. I'll follow up with an additional PR which makes a sweep of the entire repo.
Also the declared type is not of kwargs but rather **kwargs so instead of Dict[str, Any] it should be the type of the value, thus Any is correct.
john-bodley
force-pushed
the
john-bodley--mypy-spit-and-polish
branch
from
3f2e70e
to
180ea2b
Compare
8 tasks
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
Co-authored-by: John Bodley <john.bodley@airbnb.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Spit-and-polish Mypy pass which strictly enforces Mypy checks for all Python files except the
testsmodule. Note previously the rigorous tests only applied to thesupersetmodule which meant scripts, etc. were excluded.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION