chore: Mypy fix **kwargs type

[john-bodley]

SUMMARY

A follow up to #15757 (comment), per the Mypy documentation,

*args and **kwargs arguments can be annotated like so:

def stars(*args: int, **kwargs: float) -> None:
   # 'args' has type 'Tuple[int, ...]' (a tuple of ints)
   # 'kwargs' has type 'Dict[str, float]' (a dict of strs to floats)
   for arg in args:
       print(arg)
   for key, value in kwargs:
       print(key, value)

though kwargs is a Dict[str, ...] the typing of **kwargs is actually the dictionary value type.

TESTING INSTRUCTIONS

CI. Found all violations by running git grep "**kwargs: Dict".

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[john-bodley]

The bool is incorrect given the logic below,

rison_dict = kwargs["rison"]
window_size = rison_dict.get("window_size")

i.e., clearly the type of the kwargs value (rison_dict) is of type Dict[str, ...] rather than bool.

[ktmud]

can we maybe move rison_dict to named arg and get rid of kwargs?

[john-bodley]

@ktmud I think it's a tad more complex that that as I believe the information is being provided by the @rison decorator.

[codecov]

Codecov Report

Merging #15823 (8c69cff) into master (ab4e3b9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8c69cff differs from pull request most recent head 0f9d05b. Consider uploading reports for the commit 0f9d05b to get more accurate results

@@            Coverage Diff             @@
##           master   #15823      +/-   ##
==========================================
- Coverage   76.91%   76.89%   -0.02%     
==========================================
  Files         984      984              
  Lines       51662    51622      -40     
  Branches     6991     6991              
==========================================
- Hits        39736    39697      -39     
+ Misses      11702    11701       -1     
  Partials      224      224              

Flag	Coverage Δ
mysql	81.56% <100.00%> (ø)
postgres	81.56% <100.00%> (-0.03%)	⬇️
python	81.65% <100.00%> (-0.03%)	⬇️
sqlite	81.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/annotation_layers/annotations/api.py	84.96% <ø> (ø)
superset/reports/logs/api.py	94.11% <ø> (ø)
superset/charts/api.py	86.80% <100.00%> (ø)
superset/dashboards/api.py	92.95% <100.00%> (ø)
superset/utils/decorators.py	92.59% <100.00%> (-0.27%)	⬇️
superset/models/dashboard.py	74.77% <0.00%> (-2.22%)	⬇️
superset/common/query_context.py	81.42% <0.00%> (-0.40%)	⬇️
superset/utils/cache.py	74.28% <0.00%> (-0.25%)	⬇️
superset/reports/notifications/base.py	95.23% <0.00%> (-0.22%)	⬇️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab4e3b9...0f9d05b. Read the comment docs.

[ktmud]

Lgtm