New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): show multi queries results in View query modal and data pane #15840
Conversation
/testenv up |
@junlincc Ephemeral environment spinning up at http://35.167.164.115:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Product sign-off LGTM, thanks for the fix!!
9e393c4
to
3ce834a
Compare
Codecov Report
@@ Coverage Diff @@
## master #15840 +/- ##
==========================================
- Coverage 77.09% 77.08% -0.02%
==========================================
Files 984 984
Lines 51782 51787 +5
Branches 7028 7031 +3
==========================================
- Hits 39920 39918 -2
- Misses 11637 11644 +7
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ephemeral environment shutdown and build artifacts deleted. |
… pane (apache#15840) * fix(explore): show multiple queries in View query modal * show multiple queries result in data pane * fix tests * lint fix
… pane (apache#15840) * fix(explore): show multiple queries in View query modal * show multiple queries result in data pane * fix tests * lint fix
… pane (apache#15840) * fix(explore): show multiple queries in View query modal * show multiple queries result in data pane * fix tests * lint fix
SUMMARY
Before, when user used a chart that sends multiple queries (such as Mixed Time Series chart), View query modal and data pane were showing results of only the first query. This PR fixes that behaviour.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: see #15344
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @junlincc @jinghua-qa