Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): show multi queries results in View query modal and data pane #15840

Merged
merged 4 commits into from Jul 23, 2021

Conversation

kgabryje
Copy link
Member

SUMMARY

Before, when user used a chart that sends multiple queries (such as Mixed Time Series chart), View query modal and data pane were showing results of only the first query. This PR fixes that behaviour.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: see #15344
After:
image

TESTING INSTRUCTIONS

  1. Open Mixed Time Series chart and run queries
  2. Verify that data pane shows results of metrics from both queries
  3. Verify that View query modal shows both queries
  4. Switch to a chart that sends only 1 query (e.g. Line chart)
  5. Verify that everything works as before

ADDITIONAL INFORMATION

CC @junlincc @jinghua-qa

@junlincc
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://35.167.164.115:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product sign-off LGTM, thanks for the fix!!

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #15840 (6149a87) into master (9c854ff) will decrease coverage by 0.01%.
The diff coverage is 23.52%.

❗ Current head 6149a87 differs from pull request most recent head 658dd13. Consider uploading reports for the commit 658dd13 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15840      +/-   ##
==========================================
- Coverage   77.09%   77.08%   -0.02%     
==========================================
  Files         984      984              
  Lines       51782    51787       +5     
  Branches     7028     7031       +3     
==========================================
- Hits        39920    39918       -2     
- Misses      11637    11644       +7     
  Partials      225      225              
Flag Coverage Δ
javascript 71.73% <23.52%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/explore/components/DataTablesPane/index.tsx 78.12% <11.11%> (-6.15%) ⬇️
...src/explore/components/controls/ViewQueryModal.tsx 76.00% <37.50%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c854ff...658dd13. Read the comment docs.

@kgabryje kgabryje merged commit d408ff8 into apache:master Jul 23, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
… pane (apache#15840)

* fix(explore): show multiple queries in View query modal

* show multiple queries result in data pane

* fix tests

* lint fix
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
… pane (apache#15840)

* fix(explore): show multiple queries in View query modal

* show multiple queries result in data pane

* fix tests

* lint fix
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
… pane (apache#15840)

* fix(explore): show multiple queries in View query modal

* show multiple queries result in data pane

* fix tests

* lint fix
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M test:case 🚢 1.3.0
Projects
None yet
3 participants