Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert DEFAULT_SQLLAB_LIMIT to default #15869

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

Revert change introduced by mistake in #14420.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #15869 (543d30c) into master (d408ff8) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head 543d30c differs from pull request most recent head 7fff4b5. Consider uploading reports for the commit 7fff4b5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15869      +/-   ##
==========================================
- Coverage   77.08%   76.94%   -0.14%     
==========================================
  Files         984      984              
  Lines       51787    51787              
  Branches     7031     7031              
==========================================
- Hits        39918    39849      -69     
- Misses      11644    11713      +69     
  Partials      225      225              
Flag Coverage Δ
hive ?
mysql 81.53% <100.00%> (ø)
postgres 81.55% <100.00%> (ø)
presto 81.28% <100.00%> (ø)
python 81.82% <100.00%> (-0.26%) ⬇️
sqlite 81.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.24% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.44% <0.00%> (-17.07%) ⬇️
superset/connectors/sqla/models.py 89.71% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 88.12% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d408ff8...7fff4b5. Read the comment docs.

@betodealmeida betodealmeida merged commit f9b7250 into master Jul 23, 2021
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Jul 23, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the revert_DEFAULT_SQLLAB_LIMIT branch March 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants