Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds the tests that need to be coded for the Select component #15885

Merged
merged 1 commit into from
Jul 25, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds the tests that need to be coded for the Select component.

@junlincc @rusackas @geido

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido
Copy link
Member

geido commented Jul 24, 2021

Hey. Would you like to add an initial test to this maybe? even just checking that the component renders? Otherwise this looks a bit dry ;p

@michael-s-molina
Copy link
Member Author

Hey. Would you like to add an initial test to this maybe? even just checking that the component renders? Otherwise this looks a bit dry ;p

Done.

@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #15885 (d464c25) into master (d408ff8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15885      +/-   ##
==========================================
- Coverage   77.08%   77.08%   -0.01%     
==========================================
  Files         984      984              
  Lines       51787    51791       +4     
  Branches     7031     7037       +6     
==========================================
+ Hits        39918    39921       +3     
- Misses      11644    11645       +1     
  Partials      225      225              
Flag Coverage Δ
javascript 71.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 73.05% <100.00%> (+0.12%) ⬆️
...c/components/ErrorMessage/DatabaseErrorMessage.tsx 90.90% <0.00%> (-3.83%) ⬇️
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 61.70% <0.00%> (ø)
...ponents/controls/VizTypeControl/VizTypeGallery.tsx 94.26% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d408ff8...d464c25. Read the comment docs.

@geido geido merged commit 9c81599 into apache:master Jul 25, 2021
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... thanks for these comments. Fleshing these out will be much easier to collaborate on now.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants