Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Download as image of dashboard chart did not work #15897

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #15872

@junlincc @jinghua-qa

AFTER SCREENSHOTS OR ANIMATED GIF

screen-recording-2021-07-26-at-113701-am_ftfdmunZ.mp4

TESTING INSTRUCTIONS

Check the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #15897 (e5777ca) into master (7330aef) will decrease coverage by 0.00%.
The diff coverage is 14.28%.

❗ Current head e5777ca differs from pull request most recent head 965ab99. Consider uploading reports for the commit 965ab99 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15897      +/-   ##
==========================================
- Coverage   77.08%   77.08%   -0.01%     
==========================================
  Files         984      984              
  Lines       51787    51793       +6     
  Branches     7036     7040       +4     
==========================================
+ Hits        39920    39923       +3     
- Misses      11642    11645       +3     
  Partials      225      225              
Flag Coverage Δ
javascript 71.72% <14.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/utils/downloadAsImage.ts 41.37% <0.00%> (-8.63%) ⬇️
superset-frontend/src/components/Select/Select.tsx 73.05% <100.00%> (+0.12%) ⬆️
superset/db_engine_specs/presto.py 90.31% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7330aef...965ab99. Read the comment docs.

@pkdotson
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment spinning up at http://54.68.193.161:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@junlincc
Copy link
Member

LGTM! thanks for the fix!

@junlincc junlincc added rush! Requires immediate attention #bug:blocking! Blocking issues with high priority labels Jul 26, 2021
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTG!

@michael-s-molina michael-s-molina merged commit 7aeb150 into apache:master Jul 26, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@junlincc junlincc moved this from In Review to Done in Community Usability Bash! 🐛🐞🕷 Jul 28, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels #bug:blocking! Blocking issues with high priority rush! Requires immediate attention size/S 🚢 1.3.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[dashboard] 'Download as image' in chart 3 dot menu on dashboard did not work
4 participants