Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DB add modal #15981

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Add DB modal is not working due to recent GSheets changes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

With this PR I was able to add a Druid database. I assume the error happens with other DBs as well.

ADDITIONAL INFORMATION

  • Has associated issue: [Add Database] Adding Apache Druid database entry is broken #15976
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #15981 (f78e208) into master (2d61f15) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head f78e208 differs from pull request most recent head 0031092. Consider uploading reports for the commit 0031092 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15981      +/-   ##
==========================================
- Coverage   77.05%   77.04%   -0.01%     
==========================================
  Files         988      988              
  Lines       52387    52387              
  Branches     6626     6626              
==========================================
- Hits        40367    40364       -3     
- Misses      11796    11799       +3     
  Partials      224      224              
Flag Coverage Δ
javascript 71.55% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 44.89% <0.00%> (ø)
superset-frontend/src/components/Select/Select.tsx 73.05% <0.00%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d61f15...0031092. Read the comment docs.

@hughhhh hughhhh merged commit f1b57c0 into apache:master Jul 30, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants