fix(explore): fix undefined error when using dnd

[kgabryje]

SUMMARY

When user tried to drag and drop value from a control to a different control of the same type, an undefined error occurred. The root of the issue was in reordering logic - in order the rearrange values, control's dnd handler had to accept a given drag item type. However if there were more controls of the same type in control panel, user could drag them to the other control, which wasn't handled in any way. This PR fixes the issue by changing control's dnd type from a generic one (like "Column", "Metric" etc.) to a more specific one (old type concatenated with control's name and label to ensure uniqueness).
In the future, we'll enhance the DnD experience by allowing user to drag and drop items across different controls (instead of prohibiting it). However, that will require deeper, riskier changes, so for now let's just fix the "undefined" error with this PR.
While I was at it, I introduced a few simple performance improvements - mostly wrapping stuff in useCallbacks and useMemos.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: see #16009

After:
https://user-images.githubusercontent.com/15073128/127839347-f0e4e9af-c10c-4e8c-a426-03987e8180d7.mov

TESTING INSTRUCTIONS

0. Enable drag and drop
1. Create a chart which has multiple controls of the same type, for example table or pivot table
2. Add values to controls of the same type (e.g Metric and Percentage Metric in Table, or Columns and Rows in Pivot Table)
3. Try to drag a value from 1 control to the other.
4. Verify that nothing happened and no "undefined" error is shown

ADDITIONAL INFORMATION

• Has associated issue: closes [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric' #16009, closes [d&d][bubble chart] 'Bubble size' seems able to accept drop from 'Metric for color' and Run query will lead to chart fail #16007
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

CC: @jinghua-qa @junlincc

[codecov]

Codecov Report

Merging #16020 (b452de8) into master (46188c1) will decrease coverage by 0.09%.
The diff coverage is 52.89%.

❗ Current head b452de8 differs from pull request most recent head e71b5f6. Consider uploading reports for the commit e71b5f6 to get more accurate results

@@            Coverage Diff             @@
##           master   #16020      +/-   ##
==========================================
- Coverage   77.03%   76.94%   -0.10%     
==========================================
  Files         989      990       +1     
  Lines       52413    52491      +78     
  Branches     6634     6642       +8     
==========================================
+ Hits        40378    40389      +11     
- Misses      11812    11878      +66     
- Partials      223      224       +1     

Flag	Coverage Δ
javascript	71.49% <36.68%> (-0.03%)	⬇️
presto	?
sqlite	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/controls/MetricControl/MetricDefinitionValue.jsx	80.00% <ø> (ø)
...mponents/controls/MetricControl/MetricsControl.jsx	82.94% <ø> (+0.48%)	⬆️
superset/security/manager.py	91.90% <ø> (ø)
...ontrols/DndColumnSelectControl/DndFilterSelect.tsx	45.07% <26.98%> (-0.46%)	⬇️
...ontrols/DndColumnSelectControl/DndMetricSelect.tsx	42.06% <30.90%> (+1.02%)	⬆️
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx	61.11% <38.46%> (-3.48%)	⬇️
...nents/controls/MetricControl/AdhocMetricOption.jsx	75.00% <50.00%> (+2.27%)	⬆️
...erset-frontend/src/datasource/DatasourceEditor.jsx	74.15% <66.66%> (-0.85%)	⬇️
superset/connectors/sqla/utils.py	87.50% <87.50%> (ø)
superset/views/datasource.py	90.12% <95.00%> (+1.59%)	⬆️
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46188c1...e71b5f6. Read the comment docs.

[villebro]

LGTM, thanks for the fix! For future PRs it might be better to separate into two separate PRs; one with just the fix and another with the perf improvements (easier for the lazy reviewers like myself :D)

[junlincc]

/testenv up ENABLE_EXPLORE_DRAG_AND_DROP=true

[github-actions]

@junlincc Ephemeral environment spinning up at http://34.222.129.96:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[zhaoyongjie]

LGTM

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.