fix(explore): drag & drop column select component triggering onChange unnecessarily

[suddjian]

SUMMARY

Fixes #16016

The example had a value for the granularity_sqla field that was not found in the dataset. When that happens, the mechanism that is meant to detect changes in dataset thinks that there has been a change. The fix for this is to only begin checking for dataset changes after the first render.

AFTER

Chart appears as normal rather than requiring user to click Run.

TESTING INSTRUCTIONS

Open the Calendar Heatmap example chart.

ADDITIONAL INFORMATION

• Has associated issue: [drag & drop][Calendar Heatmap]Example chart 'Calendar Heatmap' is not shown automatically with d&d on  #16016
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #16073 (ee81921) into master (4cb79e5) will decrease coverage by 0.12%.
The diff coverage is 54.05%.

❗ Current head ee81921 differs from pull request most recent head 3d8cfa7. Consider uploading reports for the commit 3d8cfa7 to get more accurate results

@@            Coverage Diff             @@
##           master   #16073      +/-   ##
==========================================
- Coverage   76.90%   76.77%   -0.13%     
==========================================
  Files         995      995              
  Lines       52842    52878      +36     
  Branches     6709     6720      +11     
==========================================
- Hits        40640    40599      -41     
- Misses      11976    12053      +77     
  Partials      226      226              

Flag	Coverage Δ
hive	81.34% <67.44%> (+0.01%)	⬆️
javascript	71.23% <35.48%> (-0.09%)	⬇️
mysql	81.55% <67.44%> (-0.07%)	⬇️
postgres	81.58% <67.44%> (-0.07%)	⬇️
presto	?
python	81.99% <67.44%> (-0.18%)	⬇️
sqlite	81.26% <67.44%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ters/FiltersConfigModal/FiltersConfigForm/utils.ts	90.47% <ø> (ø)
...FormattingControl/ConditionalFormattingControl.tsx	21.66% <0.00%> (-0.75%)	⬇️
...onalFormattingControl/FormattingPopoverContent.tsx	29.26% <0.00%> (-4.07%)	⬇️
superset-frontend/src/reports/actions/reports.js	10.86% <0.00%> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx	44.53% <0.00%> (-0.36%)	⬇️
...set-frontend/src/views/CRUD/data/database/types.ts	100.00% <ø> (ø)
superset/examples/random_time_series.py	19.44% <ø> (ø)
superset/viz.py	56.57% <ø> (ø)
superset/commands/importers/v1/examples.py	35.44% <10.00%> (-2.59%)	⬇️
.../ReportModal/HeaderReportActionsDropdown/index.tsx	24.32% <25.00%> (-1.39%)	⬇️
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb79e5...3d8cfa7. Read the comment docs.

[kgabryje]

/testenv up FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true

[github-actions]

@kgabryje Ephemeral environment spinning up at http://34.210.68.147:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[kgabryje]

1 small nit, other than that LGTM

[geido]

LGTM!

[junlincc]

seeing a missing chart in the slack dashboard. i dont think it's related, but it's probably a good idea to double check?

[suddjian]

missing image is unrelated, that's cdn.brandfolder.com's problem

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[rosemarie-chiu]

🏷 2021.31